Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c45525de608064e81268aed329013cdce06d9f79
https://github.com/WebKit/WebKit/commit/c45525de608064e81268aed329013cdce06d9f79
Author: Alex Christensen <[email protected]>
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
M Source/WebKit/Shared/WebPageCreationParameters.h
M Source/WebKit/Shared/WebPageCreationParameters.serialization.in
M Source/WebKit/UIProcess/RemotePageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.h
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
Log Message:
-----------
[Site Isolation] Clean up code from initial prototyping
https://bugs.webkit.org/show_bug.cgi?id=275135
rdar://116201135
Reviewed by Sihui Liu.
In this PR I do 2 cleanups that don't change behavior:
1. I rename SubframeProcessPageParameters to RemotePageParameters which better
reflects its use.
In the initial prototyping of site isolation I wasn't sure how we would handle
window.open and
my initial use of RemoteFrames in a process was only for remote subframes.
Renaming to RemotePageParameters
better reflects that the WebPage is communicating with a RemotePageProxy,
whether it's for an iframe
or window.open.
2. I remove the oddly named variable receivedMainFrameIdentifierFromUIProcess
and replace it with
a parameters.remotePageParameters check for its one use, preventing the
unnecessary IPC
Messages::WebPageProxy::DidCreateMainFrame when making a remote page, where the
UI process already
knows the main frame's identifier. I also moved the IPC sending from WebFrame
to WebPage,
which won't change behavior but removes an unneeded function parameter and it
reflects the WebPage's
responsibility for creating frames rather than WebFrame reporting that it was
created by the WebPage.
* Source/WebKit/Shared/WebPageCreationParameters.h:
* Source/WebKit/Shared/WebPageCreationParameters.serialization.in:
* Source/WebKit/UIProcess/RemotePageProxy.cpp:
(WebKit::RemotePageProxy::injectPageIntoNewProcess):
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::creationParametersForRemotePage):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::initWithCoreMainFrame):
* Source/WebKit/WebProcess/WebPage/WebFrame.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::m_unifiedTextReplacementController):
Canonical link: https://commits.webkit.org/279748@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
