Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6d7fa27729b7e6308aff5b13638b0f7c514888c9
https://github.com/WebKit/WebKit/commit/6d7fa27729b7e6308aff5b13638b0f7c514888c9
Author: Carlos Bentzen <[email protected]>
Date: 2024-06-05 (Wed, 05 Jun 2024)
Changed paths:
A LayoutTests/webrtc/msid-setCodecPreferences-expected.txt
A LayoutTests/webrtc/msid-setCodecPreferences.html
M
Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp
Log Message:
-----------
[GStreamer][WebRTC] Missing a=msid in offer after setting codec preferences
https://bugs.webkit.org/show_bug.cgi?id=275157
Reviewed by Philippe Normand.
When setting codec preferences on GstWebRTCRTPTransceiver, the caps object
did not contain an "a-msid" field, which causes the offer created by the
webrtcbin containing that transceiver to not include an `a=msid` line for it.
The issue is fixed by reusing the `a-msid` field from the pre-existent
codec preference, if one exists.
* LayoutTests/webrtc/msid-setCodecPreferences-expected.txt: Added.
* LayoutTests/webrtc/msid-setCodecPreferences.html: Added.
*
Source/WebCore/Modules/mediastream/gstreamer/GStreamerRtpTransceiverBackend.cpp:
(WebCore::getMsidFromCurrentCodecPreferences):
(WebCore::GStreamerRtpTransceiverBackend::setCodecPreferences):
Canonical link: https://commits.webkit.org/279746@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
