Diff
Modified: trunk/LayoutTests/ChangeLog (110955 => 110956)
--- trunk/LayoutTests/ChangeLog 2012-03-16 07:31:44 UTC (rev 110955)
+++ trunk/LayoutTests/ChangeLog 2012-03-16 07:34:51 UTC (rev 110956)
@@ -1,3 +1,14 @@
+2012-03-16 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r110951.
+ http://trac.webkit.org/changeset/110951
+ https://bugs.webkit.org/show_bug.cgi?id=81316
+
+ Does not build on apple-mac (Requested by abarth on #webkit).
+
+ * webaudio/dynamicscompressor-basic-expected.txt:
+ * webaudio/dynamicscompressor-basic.html:
+
2012-03-16 Mike Reed <r...@google.com>
to be rebaselined after hairline clipping fix in skia lands
Modified: trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt (110955 => 110956)
--- trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt 2012-03-16 07:31:44 UTC (rev 110955)
+++ trunk/LayoutTests/webaudio/dynamicscompressor-basic-expected.txt 2012-03-16 07:34:51 UTC (rev 110956)
@@ -5,8 +5,6 @@
PASS threshold attribute has correct default value.
PASS knee attribute has correct default value.
PASS ratio attribute has correct default value.
-PASS attack attribute has correct default value.
-PASS release attribute has correct default value.
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/webaudio/dynamicscompressor-basic.html (110955 => 110956)
--- trunk/LayoutTests/webaudio/dynamicscompressor-basic.html 2012-03-16 07:31:44 UTC (rev 110955)
+++ trunk/LayoutTests/webaudio/dynamicscompressor-basic.html 2012-03-16 07:34:51 UTC (rev 110956)
@@ -43,16 +43,6 @@
else
testFailed("ratio attribute has incorrect default value.");
- if (compressor.attack.value - 0.003 < 1e-7)
- testPassed("attack attribute has correct default value.");
- else
- testFailed("attack attribute has incorrect default value.");
-
- if (compressor.release.value - 0.25 < 1e-7)
- testPassed("release attribute has correct default value.");
- else
- testFailed("release attribute has incorrect default value.");
-
} catch(e) {
testFailed("Exception thrown when accessing DynamicsCompressorNode attributes.");
}
Modified: trunk/Source/WebCore/ChangeLog (110955 => 110956)
--- trunk/Source/WebCore/ChangeLog 2012-03-16 07:31:44 UTC (rev 110955)
+++ trunk/Source/WebCore/ChangeLog 2012-03-16 07:34:51 UTC (rev 110956)
@@ -1,3 +1,20 @@
+2012-03-16 Sheriff Bot <webkit.review....@gmail.com>
+
+ Unreviewed, rolling out r110951.
+ http://trac.webkit.org/changeset/110951
+ https://bugs.webkit.org/show_bug.cgi?id=81316
+
+ Does not build on apple-mac (Requested by abarth on #webkit).
+
+ * platform/audio/DynamicsCompressor.h:
+ (DynamicsCompressor):
+ * webaudio/DynamicsCompressorNode.cpp:
+ (WebCore::DynamicsCompressorNode::DynamicsCompressorNode):
+ (WebCore::DynamicsCompressorNode::process):
+ * webaudio/DynamicsCompressorNode.h:
+ (DynamicsCompressorNode):
+ * webaudio/DynamicsCompressorNode.idl:
+
2012-03-16 Seo Sanghyeon <sh4....@samsung.com>
Cleanup empty attribute list in IDLs
Modified: trunk/Source/WebCore/platform/audio/DynamicsCompressor.h (110955 => 110956)
--- trunk/Source/WebCore/platform/audio/DynamicsCompressor.h 2012-03-16 07:31:44 UTC (rev 110955)
+++ trunk/Source/WebCore/platform/audio/DynamicsCompressor.h 2012-03-16 07:34:51 UTC (rev 110956)
@@ -85,6 +85,8 @@
unsigned m_numberOfChannels;
// m_parameters holds the tweakable compressor parameters.
+ // FIXME: expose some of the most important ones (such as threshold, attack, release)
+ // as DynamicsCompressorNode attributes.
float m_parameters[ParamLast];
void initializeParameters();
Modified: trunk/Source/WebCore/webaudio/DynamicsCompressorNode.cpp (110955 => 110956)
--- trunk/Source/WebCore/webaudio/DynamicsCompressorNode.cpp 2012-03-16 07:31:44 UTC (rev 110955)
+++ trunk/Source/WebCore/webaudio/DynamicsCompressorNode.cpp 2012-03-16 07:34:51 UTC (rev 110956)
@@ -50,15 +50,11 @@
m_knee = AudioParam::create("knee", 30, 0, 40);
m_ratio = AudioParam::create("ratio", 12, 1, 20);
m_reduction = AudioParam::create("reduction", 0, -20, 0);
- m_attack = AudioParam::create("attack", 0.003, 0, 1);
- m_release = AudioParam::create("release", 0.250, 0, 1);
m_threshold->setContext(context);
m_knee->setContext(context);
m_ratio->setContext(context);
m_reduction->setContext(context);
- m_attack->setContext(context);
- m_release->setContext(context);
initialize();
}
@@ -76,14 +72,10 @@
float threshold = m_threshold->value();
float knee = m_knee->value();
float ratio = m_ratio->value();
- float attack = m_attack->value();
- float release = m_release->value();
m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamThreshold, threshold);
m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamKnee, knee);
m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamRatio, ratio);
- m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamAttack, attack);
- m_dynamicsCompressor->setParameterValue(DynamicsCompressor::ParamRelease, release);
m_dynamicsCompressor->process(input(0)->bus(), outputBus, framesToProcess);
Modified: trunk/Source/WebCore/webaudio/DynamicsCompressorNode.h (110955 => 110956)
--- trunk/Source/WebCore/webaudio/DynamicsCompressorNode.h 2012-03-16 07:31:44 UTC (rev 110955)
+++ trunk/Source/WebCore/webaudio/DynamicsCompressorNode.h 2012-03-16 07:34:51 UTC (rev 110956)
@@ -52,8 +52,6 @@
AudioParam* threshold() { return m_threshold.get(); }
AudioParam* knee() { return m_knee.get(); }
AudioParam* ratio() { return m_ratio.get(); }
- AudioParam* attack() { return m_attack.get(); }
- AudioParam* release() { return m_release.get(); }
// Amount by which the compressor is currently compressing the signal in decibels.
AudioParam* reduction() { return m_reduction.get(); }
@@ -69,8 +67,6 @@
RefPtr<AudioParam> m_knee;
RefPtr<AudioParam> m_ratio;
RefPtr<AudioParam> m_reduction;
- RefPtr<AudioParam> m_attack;
- RefPtr<AudioParam> m_release;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/webaudio/DynamicsCompressorNode.idl (110955 => 110956)
--- trunk/Source/WebCore/webaudio/DynamicsCompressorNode.idl 2012-03-16 07:31:44 UTC (rev 110955)
+++ trunk/Source/WebCore/webaudio/DynamicsCompressorNode.idl 2012-03-16 07:34:51 UTC (rev 110956)
@@ -31,7 +31,5 @@
readonly attribute AudioParam knee; // in Decibels
readonly attribute AudioParam ratio; // unit-less
readonly attribute AudioParam reduction; // in Decibels
- readonly attribute AudioParam attack; // in Seconds
- readonly attribute AudioParam release; // in Seconds
};
}
