Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 53be00f7a1fc6ceb136d6b838a100821c99691f0
https://github.com/WebKit/WebKit/commit/53be00f7a1fc6ceb136d6b838a100821c99691f0
Author: Keith Miller <keith_mil...@apple.com>
Date: 2024-05-25 (Sat, 25 May 2024)
Changed paths:
A JSTests/wasm/stress/many-calls-results-on-stack.js
M Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
Log Message:
-----------
BBQ needs to move stack results from a call to their canonical location
https://bugs.webkit.org/show_bug.cgi?id=271175
rdar://124060867
Reviewed by Yusuke Suzuki.
Right now we can end up clobbering a value, `X`, on the stack in BBQ because it
gets left in a
`StackArgument` `Location` after a call. This breaks when a later call before
`X` has been consumed
would set the same `StackArgument` location as `X`. The fix is to just always
move stack results
to their canonical location. This is probably fine because stack results are
super rare in practice.
* JSTests/wasm/stress/many-calls-results-on-stack.js: Added.
(repeat):
(check):
(async test):
* Source/JavaScriptCore/wasm/WasmBBQJIT.cpp:
(JSC::Wasm::BBQJIT::returnValuesFromCall):
Originally-landed-as: 272448.770@safari-7618-branch (6d311cd7fefc).
rdar://128550307
Canonical link: https://commits.webkit.org/279316@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
