Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: b6af5aca4e29f91506b6b59c722b8523760405dd https://github.com/WebKit/WebKit/commit/b6af5aca4e29f91506b6b59c722b8523760405dd Author: Alex Christensen <achristen...@apple.com> Date: 2024-05-17 (Fri, 17 May 2024)
Changed paths: M Source/WebKit/UIProcess/API/APINavigationClient.h M Source/WebKit/UIProcess/API/C/WKPage.cpp M Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp M Source/WebKit/UIProcess/Cocoa/NavigationState.h M Source/WebKit/UIProcess/Cocoa/NavigationState.mm M Source/WebKit/UIProcess/WebPageProxy.cpp M Source/WebKit/UIProcess/WebPageProxy.h M Tools/TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm Log Message: ----------- Pass failed load URL to createErrorWithRecoveryAttempter instead of relying on NSError.userInfo https://bugs.webkit.org/show_bug.cgi?id=274314 rdar://127180360 Reviewed by Brady Eidson. We have the URL ourselves. Let's stop relying on it being in the dictionary. * Source/WebKit/UIProcess/API/APINavigationClient.h: (API::NavigationClient::didFailProvisionalNavigationWithError): (API::NavigationClient::didFailNavigationWithError): * Source/WebKit/UIProcess/API/C/WKPage.cpp: (WKPageSetPageNavigationClient): * Source/WebKit/UIProcess/API/glib/WebKitNavigationClient.cpp: * Source/WebKit/UIProcess/Cocoa/NavigationState.h: * Source/WebKit/UIProcess/Cocoa/NavigationState.mm: (WebKit::createErrorWithRecoveryAttempter): (WebKit::NavigationState::NavigationClient::didFailProvisionalNavigationWithError): (WebKit::NavigationState::NavigationClient::didFailProvisionalLoadWithErrorForFrame): (WebKit::NavigationState::NavigationClient::didFailNavigationWithError): (WebKit::NavigationState::NavigationClient::didFailLoadWithErrorForFrame): * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::receivedNavigationActionPolicyDecision): (WebKit::WebPageProxy::didFailProvisionalLoadForFrameShared): (WebKit::WebPageProxy::didFailLoadForFrame): (WebKit::WebPageProxy::decidePolicyForNavigationAction): * Source/WebKit/UIProcess/WebPageProxy.h: Canonical link: https://commits.webkit.org/278938@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes