Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: c44af016dd217817be2b770dca6a5e81b1771366 https://github.com/WebKit/WebKit/commit/c44af016dd217817be2b770dca6a5e81b1771366 Author: Eddy Wong <eddy_w...@apple.com> Date: 2024-05-13 (Mon, 13 May 2024)
Changed paths: M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICommands.mm Log Message: ----------- REGRESSION (278619@main): [iOS] TestWebKitAPI.WKWebExtensionAPICommands.PerformKeyCommand is timing out rdar://127902100 https://bugs.webkit.org/show_bug.cgi?id=274022 Reviewed by Brian Weinstein. Updated the unit test for performing key command for web extensions. The key command will never be a firstResponder so it is incorrect to try to fire the keyCommand object directly. Instead, do what the client firstResponder would do: invoke -performCommandForKeyCommand: on the context object. * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebExtensionAPICommands.mm: (TestWebKitAPI::TEST(WKWebExtensionAPICommands, PerformKeyCommand)): Canonical link: https://commits.webkit.org/278721@main To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes