Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5f97395cfff8d3cd7effe4a5a3c31638cc50eccd
      
https://github.com/WebKit/WebKit/commit/5f97395cfff8d3cd7effe4a5a3c31638cc50eccd
  Author: Mike Wyrzykowski <mwyrzykow...@apple.com>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/webgpu/fuzz-272863-expected.txt
    A LayoutTests/fast/webgpu/fuzz-272863.html
    M Source/WebGPU/WebGPU/BindGroup.mm
    M Source/WebGPU/WebGPU/CommandEncoder.h
    M Source/WebGPU/WebGPU/CommandEncoder.mm
    M Source/WebGPU/WebGPU/ComputePassEncoder.mm
    M Source/WebGPU/WebGPU/Device.mm
    M Source/WebGPU/WebGPU/PresentationContextIOSurface.mm
    M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
    M Source/WebGPU/WebGPU/RenderPassEncoder.mm

  Log Message:
  -----------
  [WebGPU] ComputePassEncoder::setBindGroup crashes under some invalid arguments
https://bugs.webkit.org/show_bug.cgi?id=272863
<radar://126621325>

Reviewed by Tadeu Zagallo.

Fix validation errors which were largely caught at the Metal framework layer
but would result in release crashes if run with the validation layer enabled.

* LayoutTests/TestExpectations:
* LayoutTests/fast/webgpu/fuzz-272863-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-272863.html: Added.
Add regression tests, the test passes if it reaches the end.

* Source/WebGPU/WebGPU/BindGroup.mm:
(WebGPU::Device::createBindGroup):
* Source/WebGPU/WebGPU/CommandEncoder.h:
* Source/WebGPU/WebGPU/CommandEncoder.mm:
(WebGPU::CommandEncoder::ensureBlitCommandEncoder):
(WebGPU::CommandEncoder::beginComputePass):
(WebGPU::CommandEncoder::beginRenderPass):
(WebGPU::CommandEncoder::encoderIsCurrent const):
(WebGPU::CommandEncoder::copyTextureToTexture):
(WebGPU::CommandEncoder::validateFinishError const):
(WebGPU::CommandEncoder::resolveQuerySet):
* Source/WebGPU/WebGPU/ComputePassEncoder.mm:
* Source/WebGPU/WebGPU/Device.mm:
(WebGPU::Device::Device):
* Source/WebGPU/WebGPU/PresentationContextIOSurface.mm:
(WebGPU::PresentationContextIOSurface::configure):
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(WebGPU::makeRenderBundleICBWithResources):
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:

Canonical link: https://commits.webkit.org/277718@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to