Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b5ce791faf9e1635a2418f53d054dea2ddc8d442
      
https://github.com/WebKit/WebKit/commit/b5ce791faf9e1635a2418f53d054dea2ddc8d442
  Author: Antti Koivisto <[email protected]>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt
    M 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries.html
    M Source/WebCore/css/query/ContainerQueryFeatures.cpp
    M Source/WebCore/style/StyleBuilder.cpp

  Log Message:
  -----------
  [CSS Container Queries][Style queries] Incorrect difference between implicit 
and explicit initial values for custom properties
https://bugs.webkit.org/show_bug.cgi?id=270739
rdar://124573975

Reviewed by Alan Baradlay.

Make sure guaranteed-invalid values match other guaranteed-invalid values 
whether explicitly (with `initial`) or implicitly specified.

* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries-expected.txt:
* 
LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/custom-property-style-queries.html:
* Source/WebCore/css/query/ContainerQueryFeatures.cpp:

Test consistently for guaranteed-invalid values.

* Source/WebCore/style/StyleBuilder.cpp:
(WebCore::Style::Builder::resolveCustomPropertyForContainerQueries):

Return a nullptr only in failure cases (revert/revert-layer) and an invalid 
value otherwise.

Canonical link: https://commits.webkit.org/277670@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to