Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7356f4b2ed16787880fb34b55415f3ec6569f20f
https://github.com/WebKit/WebKit/commit/7356f4b2ed16787880fb34b55415f3ec6569f20f
Author: Antoine Quint <grao...@webkit.org>
Date: 2024-04-13 (Sat, 13 Apr 2024)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/test_style_flush_on_dom_api_with_d_property-expected.txt
M Source/WebCore/svg/SVGPathElement.cpp
M Source/WebCore/svg/SVGPathElement.h
Log Message:
-----------
[svg] WPT test
`svg/path/property/test_style_flush_on_dom_api_with_d_property.html` has
failures
https://bugs.webkit.org/show_bug.cgi?id=272621
Reviewed by Nikolas Zimmermann.
Since path data can be set via style now, we must make sure that layout is
updated when the various
`SVGGeometryElement` DOM methods are called for path-related computations,
including `getTotalLength()`,
`getPointAtLength()` and the `SVGPathElement` method `getPathSegAtLength()`.
This was already done
for the other `SVGGeometryElement` DOM APIs `isPointInFill()` and
`isPointInStroke()`.
We also ensure that the `SVGPathByteStream` we use to run the necessary
computations in those methods
is the one held on the `SVGRenderStyle` by making
`SVGPathElement::pathByteStream()` account for it.
*
LayoutTests/imported/w3c/web-platform-tests/svg/path/property/test_style_flush_on_dom_api_with_d_property-expected.txt:
* Source/WebCore/svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::getTotalLength const):
(WebCore::SVGPathElement::getPointAtLength const):
(WebCore::SVGPathElement::getPathSegAtLength const):
(WebCore::SVGPathElement::pathByteStream const):
* Source/WebCore/svg/SVGPathElement.h:
Canonical link: https://commits.webkit.org/277455@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
