Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3d5ca0a9487692276e62ca70fa01a426bad06aeb
      
https://github.com/WebKit/WebKit/commit/3d5ca0a9487692276e62ca70fa01a426bad06aeb
  Author: Marcus Plutowski <[email protected]>
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
    A JSTests/wasm/stress/remainder-by-constant-plusminus-1.js
    M Source/JavaScriptCore/wasm/WasmBBQJIT64.h

  Log Message:
  -----------
  Fix BBQ JIT handling of remu(x, -1)
https://bugs.webkit.org/show_bug.cgi?id=272346
rdar://121010056

Reviewed by Yusuke Suzuki.

The optimization emitModOrDiv was zeroing out the result whenever the
modulus was -1; this is only valid for signed operations, as for
unsigned modulus the above is equivalent to % UINT~_MAX, which does not
generally equal 0.

* JSTests/wasm/stress/remainder-by-constant-plusminus-1.js: Added.
(async test):
* Source/JavaScriptCore/wasm/WasmBBQJIT64.h:
(JSC::Wasm::BBQJITImpl::BBQJIT::emitModOrDiv):

Canonical link: https://commits.webkit.org/277263@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to