Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 087346e089cf2fe3c75037da7eb17553534a6fdb
https://github.com/WebKit/WebKit/commit/087346e089cf2fe3c75037da7eb17553534a6fdb
Author: Tadeu Zagallo <tzaga...@apple.com>
Date: 2024-04-05 (Fri, 05 Apr 2024)
Changed paths:
M
LayoutTests/http/tests/webgpu/webgpu/shader/validation/parse/identifiers-expected.txt
M Source/WebGPU/WGSL/Lexer.cpp
M Source/WebGPU/WGSL/Lexer.h
M Source/WebGPU/WGSL/TypeCheck.cpp
M Source/WebGPU/WebGPU.xcodeproj/project.pbxproj
M Source/WebGPU/WebGPU/ShaderModule.mm
Log Message:
-----------
[WebGPU] WGSL compiler should support unicode characters
https://bugs.webkit.org/show_bug.cgi?id=266774
rdar://120004379
Reviewed by Mike Wyrzykowski and Yusuke Suzuki.
For the most part, we already supported unicode, but the implementation for
isIdentifierStart and isIdentifierContinue needed to be updated. After this
patch
all the identifier tests in the CTS (under
shader,validation,parse,identifiers:*)
are passing.
* Source/WebGPU/WGSL/Lexer.cpp:
(WGSL::isIdentifierStart):
(WGSL::isIdentifierContinue):
(WGSL::Lexer<T>::nextToken):
* Source/WebGPU/WGSL/Lexer.h:
(WGSL::Lexer::isIdentifierStart): Deleted.
(WGSL::Lexer::isIdentifierContinue): Deleted.
* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::check):
* Source/WebGPU/WebGPU.xcodeproj/project.pbxproj:
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::Device::createShaderModule):
Canonical link: https://commits.webkit.org/277108@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
