Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0664fad19334f9d0daf9053b8d86f4edf83c7d3b
https://github.com/WebKit/WebKit/commit/0664fad19334f9d0daf9053b8d86f4edf83c7d3b
Author: Abrar Rahman Protyasha <a_protya...@apple.com>
Date: 2024-04-04 (Thu, 04 Apr 2024)
Changed paths:
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
Log Message:
-----------
[UnifiedPDF] Context menu interaction makes the selection highlight inactive
https://bugs.webkit.org/show_bug.cgi?id=272181
rdar://125931064
Reviewed by Simon Fraser.
274347@main introduced the behavior where we make selection highlights
inactive after a context menu interaction, in an attempt to match
behavior with the Preview app. This is arguably buggy behavior though,
and the selection highlight should reflect window activity state, and
just that.
This patch addresses that error by removing the state we tracked after
having made a context menu interaction, and by not consulting context
menu related state when determining whether the selection highlight
should be active.
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::paintPDFContent):
(WebKit::UnifiedPDFPlugin::handleContextMenuEvent):
(WebKit::UnifiedPDFPlugin::beginTrackingSelection):
(WebKit::UnifiedPDFPlugin::boundsForSelection const):
(WebKit::UnifiedPDFPlugin::repaintOnSelectionActiveStateChangeIfNeeded):
(WebKit::UnifiedPDFPlugin::isSelectionActiveAfterContextMenuInteraction const):
Deleted.
Canonical link: https://commits.webkit.org/277088@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
