Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b682c5819552ef9e414bf652ba4a65c36aea6871
      
https://github.com/WebKit/WebKit/commit/b682c5819552ef9e414bf652ba4a65c36aea6871
  Author: Mark Lam <mark....@apple.com>
  Date:   2024-04-01 (Mon, 01 Apr 2024)

  Changed paths:
    M Source/JavaScriptCore/heap/CompleteSubspace.cpp
    M Source/JavaScriptCore/jsc.cpp
    M Source/JavaScriptCore/runtime/OptionsList.h

  Log Message:
  -----------
  Add Options::maxHeapSizeAsRAMSizeMultiple() to limit max memory usage for 
testing.
https://bugs.webkit.org/show_bug.cgi?id=271986
rdar://125733077

Reviewed by Keith Miller.

Currently, we're only applying this max check to 
CompleteSubspace::tryAllocateSlow.

We found that adding it to LocalAllocator::allocateSlowCase can cause crashes 
due to failed
Structure allocations (which are fatal).  As a result, the testing disruption 
from those crashes
far outweigh any benefits we currently get from it.  So, we'll leave the max 
check out of
LocalAllocator::allocateSlowCase for now.

* Source/JavaScriptCore/heap/CompleteSubspace.cpp:
(JSC::CompleteSubspace::tryAllocateSlow):
* Source/JavaScriptCore/jsc.cpp:
(jscmain):
* Source/JavaScriptCore/runtime/OptionsList.h:

Canonical link: https://commits.webkit.org/276909@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to