Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ea7c4f2a062104518cc5f1eb6dddcd489392d1d7
https://github.com/WebKit/WebKit/commit/ea7c4f2a062104518cc5f1eb6dddcd489392d1d7
Author: Andy Estes <[email protected]>
Date: 2024-04-01 (Mon, 01 Apr 2024)
Changed paths:
M Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj
R Source/WebCore/PAL/pal/spi/vision/LinearMediaKitSPI.h
M Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h
M Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm
M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h
M Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h
M Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm
M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
A Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.h
A Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.swift
A Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitSPI.h
M Source/WebKit/WebKitSwift/WebKitSwift.h
Log Message:
-----------
[visionOS] When entering video fullscreen from element fullscreen, go
directly to docked mode
https://bugs.webkit.org/show_bug.cgi?id=271922
rdar://123529719
Reviewed by Jer Noble.
Updated WKFullScreenViewController to insert LMPlayableViewController's
environmentPickerButtonView
into the fullscreen controls stack view, replacing the placeholder button we
had before, and to set
properties on the LMPlayableViewController saying that it should dock when
entering fullscreen and
exit video fullscreen when undocking (thus returning to element fullscreen
directly).
* Source/WebCore/PAL/PAL.xcodeproj/project.pbxproj:
* Source/WebCore/platform/ios/VideoPresentationInterfaceIOS.h:
(WebCore::VideoPresentationInterfaceIOS::playableViewController):
* Source/WebKit/Platform/ios/PlaybackSessionInterfaceLMK.mm:
(-[WKLinearMediaPlayerDelegate linearMediaPlayerToggleInlineMode:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerWillEnterFullscreen:]):
(-[WKLinearMediaPlayerDelegate linearMediaPlayerWillExitFullscreen:]):
(-[WKLinearMediaPlayerDelegate _exitFullscreen]):
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.h:
* Source/WebKit/Platform/ios/VideoPresentationInterfaceLMK.mm:
(WebKit::VideoPresentationInterfaceLMK::setupPlayerViewController):
(WebKit::VideoPresentationInterfaceLMK::playableViewController):
(WebKit::VideoPresentationInterfaceLMK::ensurePlayableViewController):
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.h:
* Source/WebKit/UIProcess/Cocoa/VideoPresentationManagerProxy.mm:
(WebKit::VideoPresentationManagerProxy::playableViewController const):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController videoControlsManagerDidChange]):
(-[WKFullScreenViewController
_configureEnvironmentPickerButtonViewWithPlayableViewController:]):
(-[WKFullScreenViewController loadView]):
(-[WKFullScreenViewController _enterVideoFullscreenAction:]): Deleted.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.h: Copied from
Source/WebCore/PAL/pal/spi/vision/LinearMediaKitSPI.h.
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitExtras.swift: Added.
(PlayableViewController.wks_automaticallyDockOnFullScreenPresentation):
(PlayableViewController.wks_dismissFullScreenOnExitingDocking):
(PlayableViewController.wks_environmentPickerButtonViewController):
* Source/WebKit/WebKitSwift/LinearMediaKit/LinearMediaKitSPI.h: Renamed from
Source/WebCore/PAL/pal/spi/vision/LinearMediaKitSPI.h.
* Source/WebKit/WebKitSwift/WebKitSwift.h:
Canonical link: https://commits.webkit.org/276898@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes