Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a7b863a49945946c913e6e194ec047da844094a4
https://github.com/WebKit/WebKit/commit/a7b863a49945946c913e6e194ec047da844094a4
Author: Jean-Yves Avenard <j...@apple.com>
Date: 2024-03-14 (Thu, 14 Mar 2024)
Changed paths:
A LayoutTests/http/tests/media/video-src-mp4-blob-expected.txt
A LayoutTests/http/tests/media/video-src-mp4-blob.html
A LayoutTests/http/tests/media/video-src-webm-blob-expected.txt
A LayoutTests/http/tests/media/video-src-webm-blob.html
A LayoutTests/http/tests/media/video-srcobject-webm-blob-expected.txt
A LayoutTests/http/tests/media/video-srcobject-webm-blob.html
M LayoutTests/http/tests/media/white.webm
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/fileapi/ThreadableBlobRegistry.cpp
M Source/WebCore/fileapi/ThreadableBlobRegistry.h
M Source/WebCore/html/HTMLMediaElement.cpp
M Source/WebCore/html/HTMLMediaElement.h
M Source/WebCore/platform/network/BlobRegistry.h
M Source/WebCore/platform/network/BlobRegistryImpl.cpp
M Source/WebCore/platform/network/BlobRegistryImpl.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in
M Source/WebKit/NetworkProcess/NetworkProcessPlatformStrategies.cpp
M Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.cpp
M Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.h
M Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.mm
Log Message:
-----------
Safari 16 cannot play WebM Opus from blob URL (breaks Construct 3)
https://bugs.webkit.org/show_bug.cgi?id=245428
rdar://100205028
Reviewed by Youenn Fablet.
The Blob's content-type wasn't passed to the MediaPlayer preventing playback to
succeed.
Similarly, when a Blob's URL was provided, an empty content-type was used.
We add a BlobRegistry::blobType method, which similar to blobSize will fetch
the content-type
from the BlobData in the network process.
Added tests.
* LayoutTests/http/tests/media/video-src-mp4-blob-expected.txt: Added.
* LayoutTests/http/tests/media/video-src-mp4-blob.html: Added.
* LayoutTests/http/tests/media/video-src-webm-blob-expected.txt: Added.
* LayoutTests/http/tests/media/video-src-webm-blob.html: Added.
* LayoutTests/http/tests/media/video-srcobject-webm-blob-expected.txt: Added.
* LayoutTests/http/tests/media/video-srcobject-webm-blob.html: Added.
* LayoutTests/http/tests/media/white.webm: File was a mkv with a h264 video
track. Re-encoded it to use a vp9 track instead.
* LayoutTests/platform/mac-wk1/TestExpectations:
* Source/WebCore/fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::blobType):
* Source/WebCore/fileapi/ThreadableBlobRegistry.h:
* Source/WebCore/html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
* Source/WebCore/html/HTMLMediaElement.h:
* Source/WebCore/platform/network/BlobRegistry.h:
* Source/WebCore/platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::blobType):
* Source/WebCore/platform/network/BlobRegistryImpl.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::blobType):
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h:
* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* Source/WebKit/NetworkProcess/NetworkProcessPlatformStrategies.cpp:
(WebKit::NetworkProcessPlatformStrategies::createBlobRegistry):
* Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::blobType):
* Source/WebKit/WebProcess/FileAPI/BlobRegistryProxy.h:
* Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.mm:
Canonical link: https://commits.webkit.org/276136@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
