Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 5f7adde53ff63535d548a3c038b2a84b89afde3a
https://github.com/WebKit/WebKit/commit/5f7adde53ff63535d548a3c038b2a84b89afde3a
Author: Youenn Fablet <youe...@gmail.com>
Date: 2024-02-20 (Tue, 20 Feb 2024)
Changed paths:
A LayoutTests/fast/mediastream/applyConstraints-bad-constraints-expected.txt
A LayoutTests/fast/mediastream/applyConstraints-bad-constraints.html
M Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
M Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h
Log Message:
-----------
RealtimeMediaSource error logging is wrong for zoom and frame rate constraints
rdar://121949844
https://bugs.webkit.org/show_bug.cgi?id=269700
Reviewed by Eric Carlson.
Debug ASSERTs were changed into RELEASE_ASSERT in
https://github.com/WebKit/WebKit/commit/f685afa11acafdf44fd60af91b837cb1f3bf85f9.
But these asserts are hit since our loggings are mistakenly calling longRange()
for double constraints.
Update our logging code to use double constraints and add corresponding tests.
We downgrade the two RELEASE_ASSERT to ASSERT like it was the case before
https://github.com/WebKit/WebKit/commit/f685afa11acafdf44fd60af91b837cb1f3bf85f9.
A future patch should further refactor this code to remove these ASSERTS.
* LayoutTests/fast/mediastream/applyConstraints-bad-constraints-expected.txt:
Added.
* LayoutTests/fast/mediastream/applyConstraints-bad-constraints.html: Added.
* Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::hasInvalidSizeFrameRateAndZoomConstraints):
Canonical link: https://commits.webkit.org/275036@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
