Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 79f2da16787152375ec525ffea8571bba6a60102
https://github.com/WebKit/WebKit/commit/79f2da16787152375ec525ffea8571bba6a60102
Author: Philippe Normand <ph...@igalia.com>
Date: 2024-02-01 (Thu, 01 Feb 2024)
Changed paths:
M Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp
M Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
Log Message:
-----------
[GStreamer]
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audioworklet-interface/audioworkletprocessor-promises.https.html
is flaky crash
https://bugs.webkit.org/show_bug.cgi?id=268541
Reviewed by Xabier Rodriguez-Calvar.
The crash backtrace suggested the WebAudioSource element was attempting to use
a dangling pointer.
Ideally we should make the AudioDestination a weak pointer in the
WebAudioSource but that breaks
assumptions elsewhere where AudioDestination is used as a RefCounted.
* Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):
* Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcRenderAndPushFrames):
Canonical link: https://commits.webkit.org/273928@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
