Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3b0ecebf15c658e0e5ecd1e3e217ff02d491733f
https://github.com/WebKit/WebKit/commit/3b0ecebf15c658e0e5ecd1e3e217ff02d491733f
Author: Charlie Wolfe <charl...@apple.com>
Date: 2024-01-29 (Mon, 29 Jan 2024)
Changed paths:
M Source/WebKit/UIProcess/FindStringCallbackAggregator.cpp
M Source/WebKit/UIProcess/FindStringCallbackAggregator.h
M Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm
Log Message:
-----------
[Site Isolation] `findString:` should have support for backwards traversal
https://bugs.webkit.org/show_bug.cgi?id=267905
rdar://121411333
Reviewed by Alex Christensen.
When FindOptions::Backwards is passed to findString the frame traversal in the
UI process should go
backwards when finding the frame closest to the focused frame.
* Source/WebKit/UIProcess/FindStringCallbackAggregator.cpp:
(WebKit::FindStringCallbackAggregator::incrementFrame):
(WebKit::FindStringCallbackAggregator::shouldTargetFrame):
(WebKit::FindStringCallbackAggregator::~FindStringCallbackAggregator):
(WebKit::shouldTargetFrame): Deleted.
* Source/WebKit/UIProcess/FindStringCallbackAggregator.h:
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::traversePrevious const):
(WebKit::WebFrameProxy::deepLastChild const):
(WebKit::WebFrameProxy::traversePrevious): Deleted.
(WebKit::WebFrameProxy::deepLastChild): Deleted.
* Source/WebKit/UIProcess/WebFrameProxy.h:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/SiteIsolation.mm:
(TestWebKitAPI::TEST):
Use the existing tests and expect the reverse order.
Canonical link: https://commits.webkit.org/273730@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
