Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 74df988dc5b55d9cfb4795e9b641df9fc032c343
https://github.com/WebKit/WebKit/commit/74df988dc5b55d9cfb4795e9b641df9fc032c343
Author: Ryosuke Niwa <rn...@webkit.org>
Date: 2024-01-29 (Mon, 29 Jan 2024)
Changed paths:
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/Element.h
M Source/WebCore/dom/Node.h
M Source/WebCore/dom/ProcessingInstruction.cpp
M Source/WebCore/dom/ProcessingInstruction.h
M Source/WebCore/html/parser/HTMLConstructionSite.cpp
M Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp
M Source/WebCore/html/parser/HTMLElementStack.cpp
M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
Log Message:
-----------
beginParsingChildren and finishParsingChildren should only exist on Element
https://bugs.webkit.org/show_bug.cgi?id=268213
Reviewed by Anne van Kesteren and Darin Adler.
Only Element and ProcessingInstruction ever override finishParsingChildren.
ProcessingInstruction::finishParsingChildren is only there to unset
m_createdByParser
flag but this function is only ever called by
XMLDocumentParser::processingInstruction,
which can call ProcessingInstruction::setCreatedByParser instead. Furthermore,
only
Element ever implemented beginParsingChildren.
This PR therefore moves beginParsingChildren and finishParsingChildren from Node
to Element and removes ProcessingInstruction::finishParsingChildren.
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::finishParsingChildren):
(WebCore::Element::beginParsingChildren): Deleted.
* Source/WebCore/dom/Element.h:
(WebCore::Element::beginParsingChildren): Moved from cpp file.
* Source/WebCore/dom/Node.h:
(WebCore::Node::finishParsingChildren): Deleted.
(WebCore::Node::beginParsingChildren): Deleted.
* Source/WebCore/dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::finishParsingChildren): Deleted.
* Source/WebCore/dom/ProcessingInstruction.h:
* Source/WebCore/html/parser/HTMLConstructionSite.cpp:
(WebCore::executeInsertTask):
* Source/WebCore/html/parser/HTMLDocumentParserFastPath.cpp:
(WebCore::HTMLFastPathParser::parseVoidElement):
* Source/WebCore/html/parser/HTMLElementStack.cpp:
(WebCore::HTMLElementStack::popAll):
* Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::processingInstruction):
Canonical link: https://commits.webkit.org/273673@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
