Branch: refs/heads/safari-7616.1.20.10-branch Home: https://github.com/WebKit/WebKit Commit: 9a6517c05864090f4552deb9d7040943aef06667 https://github.com/WebKit/WebKit/commit/9a6517c05864090f4552deb9d7040943aef06667 Author: Myah Cobbs <mco...@apple.com> Date: 2023-06-23 (Fri, 23 Jun 2023)
Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.20.1 Identifier: 265377.1@safari-7616.1.20-branch Commit: b067c6e91cfab45a4b3a5d44ff2df0debbc3cc8d https://github.com/WebKit/WebKit/commit/b067c6e91cfab45a4b3a5d44ff2df0debbc3cc8d Author: Eric Carlson <eric.carl...@apple.com> Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/rendering/RenderVTTCue.cpp Log Message: ----------- Cherry-pick b33adedfb117. rdar://problem/93689838 ASSERTION FAILED: firstChild():[ macOS ] media/track/track-cues-missed.html is a flaky test. https://bugs.webkit.org/show_bug.cgi?id=258183 rdar://110876540 Reviewed by Andy Estes. * Source/WebCore/rendering/RenderVTTCue.cpp: (WebCore::RenderVTTCue::isOutside const): Return early if firstChild() return null. (WebCore::RenderVTTCue::isOverlapping const): Ditto. (WebCore::RenderVTTCue::overlappingObject const): Ditto. (WebCore::RenderVTTCue::moveIfNecessaryToKeepWithinContainer): Ditto. (WebCore::RenderVTTCue::findNonOverlappingPosition const): Ditto. Canonical link: https://commits.webkit.org/265420@main Identifier: 265377.2@safari-7616.1.20-branch Commit: b92693566eb2c935d505396539cea60ac09c953e https://github.com/WebKit/WebKit/commit/b92693566eb2c935d505396539cea60ac09c953e Author: Eric Carlson <eric.carl...@apple.com> Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp Log Message: ----------- Cherry-pick b9047adba096. rdar://problem/110455790 [macOS] Support WebM files with no track ID https://bugs.webkit.org/show_bug.cgi?id=258402 rdar://110455790 Reviewed by Andy Estes and David Kilzer. Although WebM track ID is a required header field some otherwise valid files don't have them. MediaTrackReader requires a track ID, so create an ID when a file doesn't have one. * Source/WebKit/Shared/mac/MediaFormatReader/MediaFormatReader.cpp: (WebKit::MediaFormatReader::didParseTracks): Canonical link: https://commits.webkit.org/265425@main Identifier: 265377.3@safari-7616.1.20-branch Commit: 93957a67d0df39654b3e51c69546f3f81e020ca5 https://github.com/WebKit/WebKit/commit/93957a67d0df39654b3e51c69546f3f81e020ca5 Author: Tyler Wilcock <tyle...@apple.com> Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/accessibility/AccessibilitySVGElement.cpp Log Message: ----------- Cherry-pick e4715d95b3a1. rdar://problem/111139655 AX: AccessibilitySVGElement::computeAccessibilityIsIgnored() should null-check its renderer before using it https://bugs.webkit.org/show_bug.cgi?id=258407 rdar://111139655 Reviewed by Chris Fleizach. This patch adds a null-check of m_renderer before dereferencing it, as failing to do so causes a crash in some scenarios. * Source/WebCore/accessibility/AccessibilitySVGElement.cpp: (WebCore::AccessibilitySVGElement::computeAccessibilityIsIgnored const): Canonical link: https://commits.webkit.org/265434@main Identifier: 265377.4@safari-7616.1.20-branch Commit: 4b570635323e694772bd5a15359f566519ffe1c9 https://github.com/WebKit/WebKit/commit/4b570635323e694772bd5a15359f566519ffe1c9 Author: Abrar Rahman Protyasha <a_protya...@apple.com> Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebKit/UIProcess/WebPageProxy.cpp M Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm Log Message: ----------- Cherry-pick 46b03afa5a23. rdar://problem/110501313 WebPageProxy::setToolTip accesses a null PageClient https://bugs.webkit.org/show_bug.cgi?id=258313 rdar://110501313 Reviewed by Chris Dumez and Wenson Hsieh. In 264455@main, we introduced `WebPageProxy::dispatchMouseDidMoveOverElementAsynchronously`, which asks to perform `WebPageProxy::mouseDidMoveOverElement` at a future time. It turns out there's a null access on `m_pageClient` when we then call into `WebPageProxy::setToolTip`, which happens because we hold a `WeakPtr<PageClient>` instance to the `PageClient` object, meaning there are no guarantees on the PageClient instance's lifetime. To avoid this null dereference, we should only inform the web page about a `MouseMove` event upon consulting whether the web page is closed through `WebPageProxy::isClosed()`. We also add an API test that crashes without this mitigation in place. * Source/WebKit/UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::dispatchMouseDidMoveOverElementAsynchronously): * Tools/TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm: (+[TestEventMonitor addLocalMonitorForEventsMatchingMask:handler:]): Canonical link: https://commits.webkit.org/265456@main Identifier: 265377.5@safari-7616.1.20-branch Commit: 235b11e29c61c63cd76e5a6a2c413ff591aa64b9 https://github.com/WebKit/WebKit/commit/235b11e29c61c63cd76e5a6a2c413ff591aa64b9 Author: Myah Cobbs <mco...@apple.com> Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.20.2 Identifier: 265377.6@safari-7616.1.20-branch Commit: d434cc12239e505ca19c53d9803c13834c31b788 https://github.com/WebKit/WebKit/commit/d434cc12239e505ca19c53d9803c13834c31b788 Author: Per Arne Vollan <pvol...@apple.com> Date: 2023-06-23 (Fri, 23 Jun 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm Log Message: ----------- Cherry-pick 4b893edcda1f. rdar://problem/109900099 Adopt delegation NEFilterSource SPI https://bugs.webkit.org/show_bug.cgi?id=258304 rdar://109900099 Reviewed by Brent Fulgham. Adopt delegation NEFilterSource SPI, providing audit token of the UI process. * Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h: * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa): Canonical link: https://commits.webkit.org/265463@main Identifier: 265377.7@safari-7616.1.20-branch Commit: 3954d62bcd4e56bc3092f158950a090a57df2185 https://github.com/WebKit/WebKit/commit/3954d62bcd4e56bc3092f158950a090a57df2185 Author: Russell Epstein <repst...@apple.com> Date: 2023-06-24 (Sat, 24 Jun 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.20.10.1 Canonical link: https://commits.webkit.org/265377.8@safari-7616.1.20.10-branch Commit: 5a073e3f48b56a25f85b6b8b95b1dba67115086f https://github.com/WebKit/WebKit/commit/5a073e3f48b56a25f85b6b8b95b1dba67115086f Author: Russell Epstein <repst...@apple.com> Date: 2023-06-26 (Mon, 26 Jun 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.20.10.2 Canonical link: https://commits.webkit.org/265377.9@safari-7616.1.20.10-branch Commit: 72c40d3b8a0c886962ff07c1a80699ff13f978c1 https://github.com/WebKit/WebKit/commit/72c40d3b8a0c886962ff07c1a80699ff13f978c1 Author: Chris Dumez <cdu...@apple.com> Date: 2023-06-26 (Mon, 26 Jun 2023) Changed paths: M Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm M Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm Log Message: ----------- Cherry-pick 0ba9e6c4473f. rdar://problem/111161160 WebPage_LoadRequest IPC fails decoding in PingDuoDuo app https://bugs.webkit.org/show_bug.cgi?id=258486 rdar://111161160 Reviewed by Tim Horton. WebPage_LoadRequest IPC was failing decoding in PingDuoDuo app. The issue was due to getting a WKSecureCodingURLWrapper instead of a NSURL when decoding the baseURL of a NSURL. I am not sure how we ended up in this situation but I made the bug go away by simplifying the code. The coder used to encode the URL in two parts: 1. The baseURL 2. The bytes from the URL's relative string Then it would decode the URL in 2 parts: 1. The baseURL 2. The bytes from the URL's relative string It would then call CFURLCreateAbsoluteURLWithBytes() with those 2 parts, which would result in an *absolute* URL. The information about baseURL / relative string would be lost. As a result, I have decided to simply encode the URL in one part, the absolute URL bytes. The decoding results ends up being the same (an absolute URL). It simplifies both coding and decoding and makes the bug go away since it was about decoding baseURLs. * Source/WebKit/Shared/Cocoa/ArgumentCodersCocoa.mm: (-[WKSecureCodingURLWrapper encodeWithCoder:]): (-[WKSecureCodingURLWrapper initWithCoder:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/IPCTestingAPI.mm: Canonical link: https://commits.webkit.org/265529@main Canonical link: https://commits.webkit.org/265377.10@safari-7616.1.20.10-branch Commit: b8853ecdd5746c21a0cf37ec606348fa90bd04bd https://github.com/WebKit/WebKit/commit/b8853ecdd5746c21a0cf37ec606348fa90bd04bd Author: Dan Robson <dtr_bugzi...@apple.com> Date: 2023-06-28 (Wed, 28 Jun 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.20.10.3 Identifier: 265377.11@safari-7616.1.20.10-branch Commit: 8e22fe7669e3d18f4813a9427988a24106588d22 https://github.com/WebKit/WebKit/commit/8e22fe7669e3d18f4813a9427988a24106588d22 Author: Robert Jenner <jen...@apple.com> Date: 2023-06-28 (Wed, 28 Jun 2023) Changed paths: M Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h M Source/WebKit/Configurations/WebKit.xcconfig M Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm Log Message: ----------- Cherry-pick 65eff3fa4fa3. rdar://problem/111427791 Revert [265376@main] Adopt delegation NEFilterSource SPI https://bugs.webkit.org/show_bug.cgi?id=258304 rdar://109900099 Unreviewed revert. Reverting commit that broke the build. * Source/WebCore/PAL/pal/spi/cocoa/NEFilterSourceSPI.h: * Source/WebKit/Configurations/WebKit.xcconfig: * Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm: (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa): Canonical link: https://commits.webkit.org/265383@main Identifier: 265377.12@safari-7616.1.20.10-branch Commit: 3a424968887f4858141916d5c378101d5e4f584f https://github.com/WebKit/WebKit/commit/3a424968887f4858141916d5c378101d5e4f584f Author: Myah Cobbs <mco...@apple.com> Date: 2023-06-29 (Thu, 29 Jun 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.20.10.4 Identifier: 263823.1567@safari-7616.1.20.10-branch Commit: e768eb4ca9ae00cd7dfa60205b40c81de848f7d1 https://github.com/WebKit/WebKit/commit/e768eb4ca9ae00cd7dfa60205b40c81de848f7d1 Author: Ryosuke Niwa <rn...@webkit.org> Date: 2023-06-29 (Thu, 29 Jun 2023) Changed paths: M Source/WebCore/editing/TextManipulationController.cpp Log Message: ----------- Cherry-pick 3f0a2a47e444. rdar://problem/85597139 Crash in TextManipulationController::observeParagraphs on macrumors.com https://bugs.webkit.org/show_bug.cgi?id=258649 Reviewed by Wenson Hsieh. In some cases, we can reach the end of shadow root without TextIterator hitting the end. We need to stop the iteration in such cases to avoid dereferencing nullptr. Unfortunately no new tests since I cannot create a reduction. * Source/WebCore/editing/TextManipulationController.cpp: (WebCore::ParagraphContentIterator::atEnd const): Canonical link: https://commits.webkit.org/265612@main Identifier: 263823.1568@safari-7616.1.20.10-branch Commit: 601164b76c35e5ce04732e7080a03e48a799b25e https://github.com/WebKit/WebKit/commit/601164b76c35e5ce04732e7080a03e48a799b25e Author: Yusuke Suzuki <ysuz...@apple.com> Date: 2023-06-29 (Thu, 29 Jun 2023) Changed paths: A JSTests/stress/int32-isnan-fold.js A JSTests/stress/int32-number-isnan-fold.js Log Message: ----------- Cherry-pick eee2dfc2c470. rdar://problem/111223515 Unreviewed, add regression tests for 265570@main https://bugs.webkit.org/show_bug.cgi?id=258596 rdar://111223515 * JSTests/stress/int32-isnan-fold.js: Added. (shouldBe): (test): * JSTests/stress/int32-number-isnan-fold.js: Added. (shouldBe): (test): Canonical link: https://commits.webkit.org/265571@main Identifier: 263823.1569@safari-7616.1.20.10-branch Commit: 00a5fa94ffadfffd16a6124608b2c971976169e5 https://github.com/WebKit/WebKit/commit/00a5fa94ffadfffd16a6124608b2c971976169e5 Author: Myah Cobbs <mco...@apple.com> Date: 2023-06-29 (Thu, 29 Jun 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.20.10.5 Identifier: 263823.1570@safari-7616.1.20.10-branch Commit: 1ea97eee6fe8a890f62cd44f0e1716ff04aa3fda https://github.com/WebKit/WebKit/commit/1ea97eee6fe8a890f62cd44f0e1716ff04aa3fda Author: Russell Epstein <repst...@apple.com> Date: 2023-07-17 (Mon, 17 Jul 2023) Changed paths: M Configurations/Version.xcconfig Log Message: ----------- Versioning. WebKit-7616.1.20.10.6 Identifier: 265377.17@safari-7616.1.20.10-branch Compare: https://github.com/WebKit/WebKit/compare/9a6517c05864%5E...1ea97eee6fe8 _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes