Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: a20dfce04b5f9d239b6372d114e029f6bbf236ec https://github.com/WebKit/WebKit/commit/a20dfce04b5f9d239b6372d114e029f6bbf236ec Author: Philippe Normand <ph...@igalia.com> Date: 2023-11-24 (Fri, 24 Nov 2023)
Changed paths: M LayoutTests/platform/glib/TestExpectations M Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp M Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp M Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp Log Message: ----------- [GStreamer][WebCodecs] New tests http/wpt/webcodecs/h264-encoder-default-config trigger critical warnings https://bugs.webkit.org/show_bug.cgi?id=265301 Reviewed by Xabier Rodriguez-Calvar. There was a confusion in kbps/bps conversion, 1 kbps is 1000 bps, not 1024 bps... We also now check the bitrate is positive and non-null before setting it on the encoder. * LayoutTests/platform/glib/TestExpectations: * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: (WebCore::GStreamerInternalVideoEncoder::initialize): * Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.cpp: * Source/WebCore/platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceGStreamer.cpp: (WebCore::RealtimeOutgoingVideoSourceGStreamer::updateStats): (WebCore::RealtimeOutgoingVideoSourceGStreamer::setParameters): (WebCore::RealtimeOutgoingVideoSourceGStreamer::fillEncodingParameters): Canonical link: https://commits.webkit.org/271099@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes