Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c31e0dd75e709ee3ffec35dc0ece60754149fdc8
https://github.com/WebKit/WebKit/commit/c31e0dd75e709ee3ffec35dc0ece60754149fdc8
Author: Alex Christensen <achristen...@apple.com>
Date: 2023-11-17 (Fri, 17 Nov 2023)
Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm
M Source/WebKit/Shared/SandboxExtension.h
A Source/WebKit/Shared/SandboxExtension.serialization.in
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
Generate serialization of SandboxExtensionHandle
https://bugs.webkit.org/show_bug.cgi?id=264994
rdar://118539219
Reviewed by Chris Dumez.
All the transformations to get this to work are pretty straightforward,
except the if (dataReference.empty()) check to deserialize a valid, null
SandboxExtensionHandle if sandboxExtensionForType somehow returns an empty
string is replaced by a fast strlen-is-greater-than-0 check in
SandboxExtensionImpl::create to return an empty handle in the creation
process rather than failing to decode and killing the creation process.
This matches existing behavior as close as possible.
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm:
(WebKit::SandboxExtensionImpl::create):
(WebKit::SandboxExtensionImpl::SandboxExtensionImpl):
(WebKit::SandboxExtensionImpl::~SandboxExtensionImpl):
(WebKit::SandboxExtensionImpl::consume):
(WebKit::SandboxExtensionImpl::invalidate):
(WebKit::SandboxExtensionImpl::getSerializedFormat):
(WebKit::SandboxExtensionImpl::sandboxExtensionForType):
(): Deleted.
(WebKit::SandboxExtensionHandle::encode): Deleted.
(WebKit::SandboxExtensionHandle::decode): Deleted.
* Source/WebKit/Shared/SandboxExtension.h:
(WebKit::SandboxExtensionImpl::SandboxExtensionImpl):
(WebKit::SandboxExtensionHandle::SandboxExtensionHandle):
(WebKit::SandboxExtensionHandle::takeImpl):
(WebKit::SandboxExtensionHandle::~SandboxExtensionHandle):
(WebKit::SandboxExtensionHandle::encode): Deleted.
(WebKit::SandboxExtensionHandle::decode): Deleted.
* Source/WebKit/Shared/SandboxExtension.serialization.in: Added.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/270904@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
