Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 5effaab5ea008dfd322164523a2253d463911715 https://github.com/WebKit/WebKit/commit/5effaab5ea008dfd322164523a2253d463911715 Author: Timothy Hatcher <timo...@apple.com> Date: 2023-11-15 (Wed, 15 Nov 2023)
Changed paths: M Source/WTF/wtf/OptionSet.h M Source/WebKit/Shared/Extensions/WebExtensionWindow.serialization.in M Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm M Source/WebKit/UIProcess/Extensions/WebExtensionTab.h M Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm M Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsEventCocoa.mm M Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWindowsEvent.h Log Message: ----------- Regression(270725@main) Many Web extensions API tests are crashing https://webkit.org/b/264885 rdar://problem/118464397 Reviewed by Chris Dumez. Remove the None and All values from Web Extension OptionSet enums, and use new OptionSet::all() instead to get a valid OptionSet for the given enum. Add back the EnumTraits for the OptionSets, since GeneratedSerializers does not generate them, and they are needed by OptionSet to check valid values. * Source/WTF/wtf/OptionSet.h: (WTF::OptionSet::all): Added. * Source/WebKit/Shared/Extensions/WebExtensionWindow.serialization.in: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (toImpl): * Source/WebKit/UIProcess/Extensions/WebExtensionTab.h: * Source/WebKit/UIProcess/Extensions/WebExtensionWindow.h: * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsCocoa.mm: (WebKit::WebExtensionAPIWindows::parseWindowTypesFilter): (WebKit::toWindowTypeFilter): (WebKit::WebExtensionContextProxy::dispatchWindowsEvent): * Source/WebKit/WebProcess/Extensions/API/Cocoa/WebExtensionAPIWindowsEventCocoa.mm: (WebKit::WebExtensionAPIWindowsEvent::invokeListenersWithArgument): * Source/WebKit/WebProcess/Extensions/API/WebExtensionAPIWindowsEvent.h: Canonical link: https://commits.webkit.org/270782@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes