Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7111a438f7c71af654f3a7d45a89820f3f503eea
https://github.com/WebKit/WebKit/commit/7111a438f7c71af654f3a7d45a89820f3f503eea
Author: Mike Wyrzykowski <mwyrzykow...@apple.com>
Date: 2023-10-30 (Mon, 30 Oct 2023)
Changed paths:
M
LayoutTests/http/tests/webgpu/webgpu/api/operation/rendering/depth_bias-expected.txt
M Source/WebCore/Modules/WebGPU/GPUDepthStencilState.h
M Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp
M Source/WebGPU/WebGPU/RenderBundleEncoder.h
M Source/WebGPU/WebGPU/RenderBundleEncoder.mm
M Source/WebGPU/WebGPU/RenderPassEncoder.mm
M Source/WebGPU/WebGPU/RenderPipeline.h
M Source/WebGPU/WebGPU/RenderPipeline.mm
Log Message:
-----------
[WebGPU] setDepthBias: is never called, depth bias and related functions are
not implemented
https://bugs.webkit.org/show_bug.cgi?id=263906
<rdar://problem/117696050>
Reviewed by Dan Glastonbury.
Call setDepthBias for regular passes and ICBs and update the test expectations.
*
LayoutTests/http/tests/webgpu/webgpu/api/operation/rendering/depth_bias-expected.txt:
* Source/WebCore/Modules/WebGPU/GPUDepthStencilState.h:
(WebCore::GPUDepthStencilState::convertToBacking const):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUDeviceImpl.cpp:
(WebCore::WebGPU::convertToBacking):
* Source/WebGPU/WebGPU/RenderBundleEncoder.h:
* Source/WebGPU/WebGPU/RenderBundleEncoder.mm:
(-[RenderBundleICBWithResources
initWithICB:pipelineState:depthStencilState:cullMode:frontFace:depthClipMode:depthBias:depthBiasSlopeScale:depthBiasClamp:]):
(WebGPU::makeRenderBundleICBWithResources):
(WebGPU::RenderBundleEncoder::endCurrentICB):
(WebGPU::icbNeedsToBeSplit):
(WebGPU::RenderBundleEncoder::setPipeline):
(-[RenderBundleICBWithResources
initWithICB:pipelineState:depthStencilState:cullMode:frontFace:depthClipMode:]):
Deleted.
* Source/WebGPU/WebGPU/RenderPassEncoder.mm:
(WebGPU::RenderPassEncoder::executeBundles):
(WebGPU::RenderPassEncoder::setPipeline):
* Source/WebGPU/WebGPU/RenderPipeline.h:
(WebGPU::RenderPipeline::create):
(WebGPU::RenderPipeline::depthBias const):
(WebGPU::RenderPipeline::depthBiasSlopeScale const):
(WebGPU::RenderPipeline::depthBiasClamp const):
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
(WebGPU::RenderPipeline::RenderPipeline):
Canonical link: https://commits.webkit.org/269995@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
