Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a96bfc4f01756793bf253fdb3154e6d3ae449519
      
https://github.com/WebKit/WebKit/commit/a96bfc4f01756793bf253fdb3154e6d3ae449519
  Author: Tyler Wilcock <[email protected]>
  Date:   2023-10-21 (Sat, 21 Oct 2023)

  Changed paths:
    M Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm
    M Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm
    M Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h

  Log Message:
  -----------
  AX: Soft-link UIAccessibility constants rather than duplicating them in iOS AX
https://bugs.webkit.org/show_bug.cgi?id=263487
rdar://problem/117287269

Reviewed by Chris Fleizach.

Duplicating them can cause conflicts when we try to link the framework they're 
defined in.
Linking the symbols also prevents bugs in case the NSString* representation 
changes in the
framework without also changing our duplicated version.

This patch also removes UIAccessibilityTokenHeadingLevel and its setting 
function,
attributeStringSetHeadingLevel, entirely, as UIAccessibilityTokenHeadingLevel 
is not used by any AT or framework.

* Source/WebCore/accessibility/cocoa/AccessibilityObjectCocoa.mm:
(WebCore::attributedStringSetFont):
(WebCore::attributedStringAppendWrapper):
* Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:
(WebCore::attributeStringSetLanguage):
(WebCore::attributeStringSetBlockquoteLevel):
(WebCore::attributeStringSetStyle):
(WebCore::attributedStringSetCompositionAttributes):
* Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.h:

Canonical link: https://commits.webkit.org/269627@main


_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to