Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 612749994064996c08fb74d25e2088ea911916b0 https://github.com/WebKit/WebKit/commit/612749994064996c08fb74d25e2088ea911916b0 Author: Tyler Wilcock <tyle...@apple.com> Date: 2023-10-11 (Wed, 11 Oct 2023)
Changed paths: M Source/WebCore/accessibility/AccessibilityObject.cpp Log Message: ----------- AX: AccessibilityObject::listMarkerTextForNodeAndPosition(Node*, Position&&) should not resolve a VisiblePosition if there is no marker https://bugs.webkit.org/show_bug.cgi?id=262990 rdar://116780655 Reviewed by Chris Fleizach. Resolving a Position to a VisiblePosition can be extraordinarily expensive, so only do it when the marker actually has text. This saves 34k samples of 46k samples on this webpage: https://developer.android.com/reference/android/view/View#attr_android:screenReaderFocusable Making the page nearly instantaneously responsive, compared to completely unresponsive for tens of seconds until VoiceOver gives up entirely prior to this patch. * Source/WebCore/accessibility/AccessibilityObject.cpp: (WebCore::AccessibilityObject::listMarkerTextForNodeAndPosition): Canonical link: https://commits.webkit.org/269208@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes