Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 026e06b1f0994cc8313bbf429d4746d937bad878
https://github.com/WebKit/WebKit/commit/026e06b1f0994cc8313bbf429d4746d937bad878
Author: Wenson Hsieh <wenson_hs...@apple.com>
Date: 2023-07-18 (Tue, 18 Jul 2023)
Changed paths:
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Log Message:
-----------
[iOS] Augment some text interaction logging to include a target location
https://bugs.webkit.org/show_bug.cgi?id=259317
Reviewed by Aditya Keerthi.
Add an optional `CGPoint` argument to
`logTextInteractionAssistantSelectionChange`, representing the
location of the text interaction gesture; this should help identify cases where
text selection is
broken due to errors when converting to the coordinate space of the content
view, and hit-testing
subsequently fails.
* Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView
changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView
changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):
(-[WKContentView changeSelectionWithTouchesFrom:to:withGesture:withState:]):
(logTextInteractionAssistantSelectionChange):
(-[WKContentView
_selectPositionAtPoint:stayingWithinFocusedElement:completionHandler:]):
(-[WKContentView
selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView
updateSelectionWithExtentPoint:withBoundary:completionHandler:]):
(-[WKContentView selectPositionAtPoint:withContextRequest:completionHandler:]):
Canonical link: https://commits.webkit.org/266145@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
