Diff
Modified: trunk/LayoutTests/ChangeLog (109305 => 109306)
--- trunk/LayoutTests/ChangeLog 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/ChangeLog 2012-03-01 05:34:33 UTC (rev 109306)
@@ -1,3 +1,21 @@
+2012-02-29 Erik Arvidsson <a...@chromium.org>
+
+ Rename DOMSelection to Selection
+ https://bugs.webkit.org/show_bug.cgi?id=79688
+
+ Reviewed by Adam Barth.
+
+ * fast/dom/Window/window-properties-expected.txt:
+ * fast/dom/dom-constructors-expected.txt:
+ * fast/dom/dom-constructors.html:
+ * platform/gtk/fast/dom/Window/window-properties-expected.txt:
+ * platform/mac/fast/dom/Window/window-properties-expected.txt:
+ * platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
+ * platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
+ * platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
+ * platform/qt/fast/dom/Window/window-properties-expected.txt:
+ * platform/win/fast/dom/Window/window-properties-expected.txt:
+
2012-02-29 Joshua Bell <jsb...@chromium.org>
IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
Modified: trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt (109305 => 109306)
--- trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -2494,7 +2494,7 @@
window.webkitConvertPointFromNodeToPage [function]
window.webkitConvertPointFromPageToNode [function]
window.window [printed above as window]
-window.getSelection() [object DOMSelection]
+window.getSelection() [object Selection]
window.getSelection().addRange [function]
window.getSelection().anchorNode [null]
window.getSelection().anchorOffset [number]
Modified: trunk/LayoutTests/fast/dom/dom-constructors-expected.txt (109305 => 109306)
--- trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/fast/dom/dom-constructors-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -115,7 +115,7 @@
PASS TryAllocate('CanvasGradient') is 'exception'
PASS TryAllocate('CanvasPattern') is 'exception'
FAIL TryAllocate('Console') should be exception. Was no constructor.
-FAIL TryAllocate('DOMSelection') should be exception. Was no constructor.
+PASS TryAllocate('Selection') is 'exception'
PASS TryAllocate('Window') is 'exception'
FAIL TryAllocate('History') should be exception. Was no constructor.
FAIL TryAllocate('HTMLOptionsCollection') should be exception. Was no constructor.
Modified: trunk/LayoutTests/fast/dom/dom-constructors.html (109305 => 109306)
--- trunk/LayoutTests/fast/dom/dom-constructors.html 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/fast/dom/dom-constructors.html 2012-03-01 05:34:33 UTC (rev 109306)
@@ -47,7 +47,7 @@
'NodeFilter', 'NodeList', 'Plugin',
'PluginArray', 'Range', 'Rect', 'StyleSheet', 'StyleSheetList',
'TextEvent', 'UIEvent', 'WheelEvent', 'XPathResult', 'BarInfo',
- 'CanvasGradient', 'CanvasPattern', 'Console', 'DOMSelection',
+ 'CanvasGradient', 'CanvasPattern', 'Console', 'Selection',
'Window', 'History', 'HTMLOptionsCollection', 'Location',
'Navigator', 'NodeIterator', 'RGBColor', 'Screen', 'TreeWalker',
'XPathExpression', 'Worker'
Modified: trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt (109305 => 109306)
--- trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -2101,6 +2101,23 @@
window.SVGViewElement.prototype [printed above as window.Element.prototype]
window.SVGZoomEvent [object SVGZoomEventConstructor]
window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
window.SharedWorker [object SharedWorkerConstructor]
window.SharedWorker.length [number]
window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2685,31 +2702,5 @@
window.webkitPostMessage [function]
window.webkitRequestAnimationFrame [function]
window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
Modified: trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt (109305 => 109306)
--- trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -2110,6 +2110,23 @@
window.SVGViewElement.prototype [printed above as window.Element.prototype]
window.SVGZoomEvent [object SVGZoomEventConstructor]
window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
window.SharedWorker [object SharedWorkerConstructor]
window.SharedWorker.length [number]
window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2705,31 +2722,5 @@
window.webkitPostMessage [function]
window.webkitRequestAnimationFrame [function]
window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
Modified: trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt (109305 => 109306)
--- trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -311,6 +311,7 @@
PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGVKernElement') is 'object'
PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGViewElement') is 'object'
PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGZoomEvent') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'Selection') is 'object'
PASS typeof Object.getOwnPropertyDescriptor(window, 'SharedWorker') is 'object'
PASS typeof Object.getOwnPropertyDescriptor(window, 'Storage') is 'object'
PASS typeof Object.getOwnPropertyDescriptor(window, 'StorageEvent') is 'object'
Modified: trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt (109305 => 109306)
--- trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -269,7 +269,6 @@
Never found HTMLHeadingElement
Never found HTMLIFrameElement
Never found HTMLImageElement
-Never found HTMLIsIndexElement
Never found HTMLKeygenElement
Never found HTMLLIElement
Never found HTMLLabelElement
@@ -448,6 +447,7 @@
Never found SVGUseElement
Never found SVGVKernElement
Never found SVGViewElement
+Never found Selection
Never found SharedWorker
Never found StyleSheet
Never found TextMetrics
Modified: trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt (109305 => 109306)
--- trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -2060,6 +2060,23 @@
window.SVGViewElement.prototype [printed above as window.Element.prototype]
window.SVGZoomEvent [object SVGZoomEventConstructor]
window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
window.SharedWorker [object SharedWorkerConstructor]
window.SharedWorker.length [number]
window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2608,31 +2625,5 @@
window.webkitPostMessage [function]
window.webkitRequestAnimationFrame [function]
window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
Modified: trunk/LayoutTests/platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt (109305 => 109306)
--- trunk/LayoutTests/platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -2044,6 +2044,23 @@
window.SVGViewElement.prototype [printed above as window.Element.prototype]
window.SVGZoomEvent [object SVGZoomEventConstructor]
window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
window.SharedWorker [object SharedWorkerConstructor]
window.SharedWorker.length [number]
window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2580,31 +2597,5 @@
window.webkitPostMessage [function]
window.webkitRequestAnimationFrame [function]
window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
Modified: trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt (109305 => 109306)
--- trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt 2012-03-01 05:34:33 UTC (rev 109306)
@@ -1991,6 +1991,23 @@
window.SVGViewElement.prototype [printed above as window.Element.prototype]
window.SVGZoomEvent [object SVGZoomEventConstructor]
window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
window.SharedWorker [object SharedWorkerConstructor]
window.SharedWorker.length [number]
window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2507,31 +2524,5 @@
window.webkitConvertPointFromNodeToPage [function]
window.webkitConvertPointFromPageToNode [function]
window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
Modified: trunk/Source/WebCore/ChangeLog (109305 => 109306)
--- trunk/Source/WebCore/ChangeLog 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/Source/WebCore/ChangeLog 2012-03-01 05:34:33 UTC (rev 109306)
@@ -1,3 +1,15 @@
+2012-02-29 Erik Arvidsson <a...@chromium.org>
+
+ Rename DOMSelection to Selection
+ https://bugs.webkit.org/show_bug.cgi?id=79688
+
+ Reviewed by Adam Barth.
+
+ No new tests. Existing tests have been updated to cover this.
+
+ * page/DOMSelection.idl:
+ * page/DOMWindow.idl:
+
2012-02-29 Joshua Bell <jsb...@chromium.org>
IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
Modified: trunk/Source/WebCore/page/DOMSelection.idl (109305 => 109306)
--- trunk/Source/WebCore/page/DOMSelection.idl 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/Source/WebCore/page/DOMSelection.idl 2012-03-01 05:34:33 UTC (rev 109306)
@@ -33,7 +33,7 @@
// https://developer.mozilla.org/En/DOM/Selection
interface [
JSGenerateIsReachable=ImplFrame,
- OmitConstructor
+ InterfaceName=Selection
] DOMSelection {
readonly attribute Node anchorNode;
readonly attribute long anchorOffset;
Modified: trunk/Source/WebCore/page/DOMWindow.idl (109305 => 109306)
--- trunk/Source/WebCore/page/DOMWindow.idl 2012-03-01 05:22:57 UTC (rev 109305)
+++ trunk/Source/WebCore/page/DOMWindow.idl 2012-03-01 05:34:33 UTC (rev 109306)
@@ -393,6 +393,7 @@
attribute ProcessingInstructionConstructor ProcessingInstruction;
attribute [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] ShadowRootConstructor WebKitShadowRoot;
+ attribute DOMSelectionConstructor Selection;
attribute DOMWindowConstructor Window;
// FIXME: Should these Canvas constructors move to html/DOMWindowHTML with the rest of canvas?
