Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: 09e40749eec19e82da91fffce3a3c43171370469 https://github.com/WebKit/WebKit/commit/09e40749eec19e82da91fffce3a3c43171370469 Author: Gerald Squelart <g_squel...@apple.com> Date: 2023-06-09 (Fri, 09 Jun 2023)
Changed paths: A LayoutTests/fast/attachment/cocoa/wide-attachment-rendering-dark-expected-mismatch.html A LayoutTests/fast/attachment/cocoa/wide-attachment-rendering-dark.html M LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt M LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt M Source/WebCore/html/shadow/attachmentElementShadow.css Log Message: ----------- Use the placeholder SVG as a mask to respect semantic color changes https://bugs.webkit.org/show_bug.cgi?id=257881 rdar://110501919 Reviewed by Tim Nguyen. When used as a background-image, SVGs do not actually change color as expected in dark mode. Instead, the SVG is now used as a mask over a semantic background color that correctly changes when appropriate. Added simple mismatch test to verify that dark appearance leads to different results from light. * LayoutTests/fast/attachment/cocoa/wide-attachment-rendering-dark-expected-mismatch.html: Added. * LayoutTests/fast/attachment/cocoa/wide-attachment-rendering-dark.html: Added. * LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt: * LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt: * Source/WebCore/html/shadow/attachmentElementShadow.css: (div#attachment-placeholder): Canonical link: https://commits.webkit.org/265037@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes