Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 952ff4b08f0bc13c601457cee68795bb7dcab25c
https://github.com/WebKit/WebKit/commit/952ff4b08f0bc13c601457cee68795bb7dcab25c
Author: David Quesada <[email protected]>
Date: 2023-06-09 (Fri, 09 Jun 2023)
Changed paths:
M Source/WebKit/UIProcess/WebPageProxy.cpp
M Tools/TestWebKitAPI/SourcesCocoa.txt
M Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
A Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewInspection.mm
Log Message:
-----------
Crash under -[WKWebView setInspectable:] if the web view has been closed
https://bugs.webkit.org/show_bug.cgi?id=257899
rdar://105191430
Reviewed by Patrick Angle.
Make WebPageProxy's inspection-related operations no-ops, instead of
unrecoverable
null pointer dereferences, if the page has been closed.
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::inspectable const):
(WebKit::WebPageProxy::setInspectable):
(WebKit::WebPageProxy::remoteInspectionNameOverride const):
(WebKit::WebPageProxy::setRemoteInspectionNameOverride):
(WebKit::WebPageProxy::remoteInspectorInformationDidChange):
* Tools/TestWebKitAPI/SourcesCocoa.txt:
* Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewInspection.mm: Added.
(TEST):
Canonical link: https://commits.webkit.org/265033@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
