Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e6f61f306afaa4ee95dc36040e166bfd037cfe75
https://github.com/WebKit/WebKit/commit/e6f61f306afaa4ee95dc36040e166bfd037cfe75
Author: Rob Buis <[email protected]>
Date: 2023-04-20 (Thu, 20 Apr 2023)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type-expected.txt
A
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type.html
M
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
A
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type-expected.txt
M Source/WebCore/html/HTMLElement.cpp
Log Message:
-----------
[popover] Fix popover-attribute-basic.html
https://bugs.webkit.org/show_bug.cgi?id=253673
Reviewed by Tim Nguyen.
In popoverAttributeChanged when hiding the popover make sure we fire
beforetoggle event.
Since this event may end up changing the popover attribute again, recompute the
type
after hiding the popover.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type-expected.txt:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type.html:
Added.
*
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
*
LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-change-type-expected.txt:
Added.
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::checkPopoverValidity):
(WebCore::HTMLElement::popoverAttributeChanged):
Canonical link: https://commits.webkit.org/263188@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
