Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d488f398f95d05b533bb5a45084b49d91c36ee84
https://github.com/WebKit/WebKit/commit/d488f398f95d05b533bb5a45084b49d91c36ee84
Author: Tyler Wilcock <[email protected]>
Date: 2023-04-19 (Wed, 19 Apr 2023)
Changed paths:
A
LayoutTests/accessibility/display-contents-descendant-menu-item-expected.txt
A LayoutTests/accessibility/display-contents-descendant-menu-item.html
M LayoutTests/accessibility/mac/aria-tree-activedescendant-expected.txt
M LayoutTests/accessibility/mac/aria-tree-activedescendant.html
M LayoutTests/platform/mac-wk1/TestExpectations
M Source/WebCore/accessibility/AccessibilityImageMapLink.h
M Source/WebCore/accessibility/AccessibilityMediaObject.cpp
M Source/WebCore/accessibility/AccessibilityMediaObject.h
M Source/WebCore/accessibility/AccessibilityObject.cpp
M Source/WebCore/accessibility/AccessibilityObject.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/AccessibilityRenderObject.h
Log Message:
-----------
AX: aria-activedescendant doesn't work for display:contents elements
https://bugs.webkit.org/show_bug.cgi?id=255648
rdar://problem/108248056
Reviewed by Chris Fleizach.
Move `shouldFocusActiveDescendant` and `activeDescendant` from
AccessibilityRenderObject to AccessibilityObject since they don't
require a renderer. Tested by new test:
display-contents-descendant-menu-item.html
Also removes two unused functions:
- isLinked
- hasControlsAttributeSet
And rewrites accessibility/mac/aria-tree-activedescendant.html to be a
more modern style layout test.
* LayoutTests/accessibility/display-contents-descendant-menu-item-expected.txt:
Added.
* LayoutTests/accessibility/display-contents-descendant-menu-item.html: Added.
* LayoutTests/platform/mac-wk1/TestExpectations: Skip new test.
* LayoutTests/accessibility/mac/aria-tree-activedescendant-expected.txt:
* LayoutTests/accessibility/mac/aria-tree-activedescendant.html:
* Source/WebCore/accessibility/AccessibilityImageMapLink.h:
* Source/WebCore/accessibility/AccessibilityMediaObject.cpp:
(WebCore::AccessibilityMediaObject::hasControlsAttributeSet const): Deleted.
* Source/WebCore/accessibility/AccessibilityMediaObject.h:
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::shouldFocusActiveDescendant const):
(WebCore::AccessibilityObject::activeDescendant const):
* Source/WebCore/accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isLinked const): Deleted.
(WebCore::AccessibilityObject::shouldFocusActiveDescendant const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::observableObject const):
(WebCore::AccessibilityRenderObject::expandedTextValue const):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant const):
Deleted.
(WebCore::AccessibilityRenderObject::activeDescendant const): Deleted.
(WebCore::AccessibilityRenderObject::isLinked const): Deleted.
* Source/WebCore/accessibility/AccessibilityRenderObject.h:
Canonical link: https://commits.webkit.org/263163@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
