Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 07f25ac1ae5727fa1bf2e242ed57e3a4efe3306a
https://github.com/WebKit/WebKit/commit/07f25ac1ae5727fa1bf2e242ed57e3a4efe3306a
Author: Gerald Squelart <g_squel...@apple.com>
Date: 2023-04-17 (Mon, 17 Apr 2023)
Changed paths:
M LayoutTests/fast/attachment/attachment-title-with-rtl-expected.html
M LayoutTests/fast/attachment/attachment-title-with-rtl.html
A
LayoutTests/fast/attachment/mac/wide-attachment-title-with-rtl-expected.html
A LayoutTests/fast/attachment/mac/wide-attachment-title-with-rtl.html
M
LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
M
LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt
M Source/WebCore/html/HTMLAttachmentElement.cpp
Log Message:
-----------
Add zero-width space before the last filename dot to avoid splitting the
extension
https://bugs.webkit.org/show_bug.cgi?id=255390
rdar://99658593
Reviewed by Cameron McCormack.
This patch also fixes an issue where the LTR isolation characters were missing
around updated filenames in wide-layout attachments; added relevant test.
* LayoutTests/fast/attachment/attachment-title-with-rtl-expected.html:
* LayoutTests/fast/attachment/attachment-title-with-rtl.html:
Tweaked test text to avoid wrapping in 2nd attachemnt; it caused sub-pixels
differences, and it's not relevant to this test.
* LayoutTests/fast/attachment/mac/wide-attachment-title-with-rtl-expected.html:
Added.
* LayoutTests/fast/attachment/mac/wide-attachment-title-with-rtl.html: Added.
Copy of non-wide tests, updated to exercise wrapping in 3rd attachment.
*
LayoutTests/platform/ios-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
*
LayoutTests/platform/mac-wk2/fast/attachment/cocoa/wide-attachment-rendering-expected.txt:
Updated to account for added character.
* Source/WebCore/html/HTMLAttachmentElement.cpp:
(WebCore::HTMLAttachmentElement::attributeChanged):
Actually use attachmentTitleForDisplay when the title changes. Also with action
and subtitles for consistency and future-proofing.
(WebCore::HTMLAttachmentElement::attachmentTitleForDisplay const):
Add zero-width spaces before dot and file extension.
Canonical link: https://commits.webkit.org/263045@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
