Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 616b690c0767730e82d452ae6031ed2e74d61e02
https://github.com/WebKit/WebKit/commit/616b690c0767730e82d452ae6031ed2e74d61e02
Author: Tyler Wilcock <[email protected]>
Date: 2023-04-08 (Sat, 08 Apr 2023)
Changed paths:
A
LayoutTests/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt
A
LayoutTests/accessibility/changing-aria-hidden-with-display-none-parent.html
A
LayoutTests/platform/glib/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt
A
LayoutTests/platform/ios-simulator/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt
M LayoutTests/platform/ios/TestExpectations
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
Log Message:
-----------
Improve Ref / RefPtr hygiene in AXObjectCache::handleAttributeChange and
AccessibilityNodeObject::textUnderElement
rdar://problem/106557770
Reviewed by Chris Fleizach.
Bring these two functions in line with the WebKit smart pointer style
guide (https://github.com/WebKit/WebKit/wiki/Smart-Pointer-Usage-Guidelines) by
reference counting AccessibilityObjects before passing them into non-trivial
functions.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::handleAttributeChange):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::textUnderElement const):
* LayoutTests/platform/ios/TestExpectations:
Mark new test as passing.
*
LayoutTests/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt:
Added.
* LayoutTests/accessibility/changing-aria-hidden-with-display-none-parent.html:
Added.
*
LayoutTests/platform/ios-simulator/accessibility/changing-aria-hidden-with-display-none-parent-expected.txt:
Added.
Cherry-pick: 259548.387@safari-7615-branch (dd026e944caa).
rdar://problem/107755793
Canonical link: https://commits.webkit.org/262753@main
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
