Title: [108817] trunk/Source/WebCore
- Revision
- 108817
- Author
- [email protected]
- Date
- 2012-02-24 10:04:35 -0800 (Fri, 24 Feb 2012)
Log Message
Don't notify the inspector of Node insertions initiated by the parser
https://bugs.webkit.org/show_bug.cgi?id=79388
Reviewed by Adam Barth.
This is part of a series of changes to make ContainerNode's
implementation simpler and more internally consistent.
I don't know of a way to break on parser-initiated insertions,
and the code already doesn't notify on parser-initiated removes
(in ContainerNode::parserRemoveChild).
No new tests, should already be covered by
inspector/debugger/dom-breakpoints.html.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserAddChild):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (108816 => 108817)
--- trunk/Source/WebCore/ChangeLog 2012-02-24 17:56:34 UTC (rev 108816)
+++ trunk/Source/WebCore/ChangeLog 2012-02-24 18:04:35 UTC (rev 108817)
@@ -1,3 +1,24 @@
+2012-02-24 Adam Klein <[email protected]>
+
+ Don't notify the inspector of Node insertions initiated by the parser
+ https://bugs.webkit.org/show_bug.cgi?id=79388
+
+ Reviewed by Adam Barth.
+
+ This is part of a series of changes to make ContainerNode's
+ implementation simpler and more internally consistent.
+
+ I don't know of a way to break on parser-initiated insertions,
+ and the code already doesn't notify on parser-initiated removes
+ (in ContainerNode::parserRemoveChild).
+
+ No new tests, should already be covered by
+ inspector/debugger/dom-breakpoints.html.
+
+ * dom/ContainerNode.cpp:
+ (WebCore::ContainerNode::parserInsertBefore):
+ (WebCore::ContainerNode::parserAddChild):
+
2012-02-24 Daniel Bates <[email protected]>
Attempt to fix the Windows and WinCE build after changeset r108809
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (108816 => 108817)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-24 17:56:34 UTC (rev 108816)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2012-02-24 18:04:35 UTC (rev 108817)
@@ -240,10 +240,6 @@
for (NodeVector::const_iterator it = targets.begin(); it != targets.end(); ++it) {
Node* child = it->get();
-#if ENABLE(INSPECTOR)
- InspectorInstrumentation::willInsertDOMNode(document(), child, this);
-#endif
-
insertBeforeCommon(next.get(), child);
childrenChanged(true, nextChildPreviousSibling.get(), nextChild, 1);
@@ -682,10 +678,6 @@
ASSERT(newChild);
ASSERT(!newChild->parentNode()); // Use appendChild if you need to handle reparenting (and want DOM mutation events).
-#if ENABLE(INSPECTOR)
- InspectorInstrumentation::willInsertDOMNode(document(), newChild.get(), this);
-#endif
-
forbidEventDispatch();
Node* last = m_lastChild;
// FIXME: This method should take a PassRefPtr.
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
