Branch: refs/heads/main Home: https://github.com/WebKit/WebKit Commit: e87820646ce924819148b2900a4458d63950672f https://github.com/WebKit/WebKit/commit/e87820646ce924819148b2900a4458d63950672f Author: Dewei Zhu <dewei_...@apple.com> Date: 2023-02-15 (Wed, 15 Feb 2023)
Changed paths: M Websites/perf.webkit.org/public/include/manifest-generator.php M Websites/perf.webkit.org/public/v3/components/pane-selector.js M Websites/perf.webkit.org/public/v3/models/platform.js M Websites/perf.webkit.org/public/v3/pages/charts-page.js M Websites/perf.webkit.org/server-tests/api-manifest-tests.js Log Message: ----------- Performance Dashboard should be able to gracefully handle hidden platforms. https://bugs.webkit.org/show_bug.cgi?id=252290 rdar://100648187 Reviewed by Ryosuke Niwa. Fix a bug that analysis task page on performance dashboard does not load properly when any platform in this task is hidden. * Websites/perf.webkit.org/public/include/manifest-generator.php: Include 'platform_hidden' field in platform manifest and stop filtering out hidden platforms in manifest. * Websites/perf.webkit.org/public/v3/components/pane-selector.js: (PaneSelector.prototype._renderPlatformList): Add code to ensure hidden platform does not show in pane. * Websites/perf.webkit.org/public/v3/models/platform.js: Added 'hidden' field and a 'isHidden' function to indicate if a platform is hidden. (Platform): (Platform.prototype.isHidden): * Websites/perf.webkit.org/public/v3/pages/charts-page.js: Filter out hidden platforms from 'ChartsPage.alternatePlatforms'. (ChartsPage): (ChartsPage.prototype.alternatePlatforms): * Websites/perf.webkit.org/server-tests/api-manifest-tests.js: Added unit test for 'Platform.isHidden'. Canonical link: https://commits.webkit.org/260325@main _______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes