Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0ba2b3fa758f25392de776de7f044a466ca397c2
https://github.com/WebKit/WebKit/commit/0ba2b3fa758f25392de776de7f044a466ca397c2
Author: Arunsundar Kannan <arunsundar_kan...@apple.com>
Date: 2023-02-09 (Thu, 09 Feb 2023)
Changed paths:
A LayoutTests/fast/html/parent-less-source-crash-type-change-expected.txt
A LayoutTests/fast/html/parent-less-source-crash-type-change.html
M Source/WebCore/html/HTMLSourceElement.cpp
Log Message:
-----------
Attribute change results in assertion failure checking for parent node for a
parent less element.
https://bugs.webkit.org/show_bug.cgi?id=251888
rdar://104819364
Reviewed by Ryosuke Niwa.
This change sets 'm_shouldCallSourcesChanged' to false after the parentNode is
disassociated from the Node in question. This will avoid the call that leads to
the crash.
* LayoutTests/fast/html/parent-less-source-crash-type-change-expected.txt:
Added.
* LayoutTests/fast/html/parent-less-source-crash-type-change.html: Added.
* Source/WebCore/dom/ContainerNodeAlgorithms.cpp:
(WebCore::removeDetachedChildrenInContainer):
* Source/WebCore/html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::setShouldCallSourcesChanged):
* Source/WebCore/html/HTMLSourceElement.h:
Canonical link: https://commits.webkit.org/260072@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
