Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3c270c15b7888c72d8d10e29bc43e40dba71e1d2
https://github.com/WebKit/WebKit/commit/3c270c15b7888c72d8d10e29bc43e40dba71e1d2
Author: Brandon Stewart <brandonstew...@apple.com>
Date: 2023-01-24 (Tue, 24 Jan 2023)
Changed paths:
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-expected.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-ref.html
A
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008.html
M Source/WebCore/rendering/GridMasonryLayout.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp
M Source/WebCore/rendering/GridTrackSizingAlgorithm.h
Log Message:
-----------
Masonry use calculated height instead of estimated height
https://bugs.webkit.org/show_bug.cgi?id=250720
Reviewed by Matt Woodrow.
The masonry calculations were being done before we had a done a proper layout.
With some refactoring the masonry layout was pushed back in the chain. This
allows
the children content to have calculated the widths and heights. Now, we can just
use the real widths and heights instead of relying on the estimated ones.
* Source/WebCore/rendering/GridMasonryLayout.cpp:
(WebCore::GridMasonryLayout::setItemGridAxisContainingBlockToGridArea):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp:
(WebCore::GridTrackSizingAlgorithm::gridAreaBreadthForChild const):
* Source/WebCore/rendering/GridTrackSizingAlgorithm.h:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-expected.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008-ref.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/masonry/tentative/item-placement/masonry-item-placement-008.html:
Added.
Canonical link: https://commits.webkit.org/259308@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
