Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a47eabf67b7048e05c86f5eff7316abe3419004f
      
https://github.com/WebKit/WebKit/commit/a47eabf67b7048e05c86f5eff7316abe3419004f
  Author: Ahmad Saleem <ahmad.saleem792+git...@gmail.com>
  Date:   2023-01-23 (Mon, 23 Jan 2023)

  Changed paths:
    M LayoutTests/editing/execCommand/indent-images-3-expected.txt
    M LayoutTests/editing/execCommand/indent-images-3.html

  Log Message:
  -----------
  Fix a broken test which calls Selection.setPosition(null)

Fix a broken test which calls Selection.setPosition(null)
https://bugs.webkit.org/show_bug.cgi?id=250572

Reviewed by Ryosuke Niwa.

Merge - 
https://chromium.googlesource.com/chromium/blink/+/26117c9b8cf6d285a554dc8fcaf0ce8a55bec626

This test calls document.getElementsByTagName('div') but there are no div 
elements.
As a result, test calls Selection.setPosition(null) and it is clearly not 
intended.
This test uses a span element instead of div element which is targeted in the 
indent-images-2.html. Thus this patch rewrite 'div' to 'span'.

This test originally expects that execCommand('indent') should not indent 
contents inside inline block.
However fixed case, which works as intended, indents the contents.
This patch does only fix broken scripts.

* LayoutTests/editing/execCommand/indent-images-3.html: Fixed Test
* LayoutTests/editing/execCommand/indent-images-3-expected.txt: Rebaselined

Canonical link: https://commits.webkit.org/259232@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to