Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ce47503cf7b8de0c5c101131fba34902a3bd6ed8
https://github.com/WebKit/WebKit/commit/ce47503cf7b8de0c5c101131fba34902a3bd6ed8
Author: Aditya Keerthi <akeer...@apple.com>
Date: 2023-01-23 (Mon, 23 Jan 2023)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/html/HTMLVideoElement.cpp
M Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
M Source/WebKit/Shared/WebPreferencesDefaultValues.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
Log Message:
-----------
REGRESSION (258393@main): Video fullscreen is unavailable if element
fullscreen is disabled
https://bugs.webkit.org/show_bug.cgi?id=250914
rdar://104433223
Reviewed by Tim Horton.
258393@main added a check for the `ENABLE(VIDEO_USES_ELEMENT_FULLSCREEN)` flag
to avoid short circuiting logic in `HTMLVideoElement::supportsFullscreen`.
However, it is possible for this flag to be true even if element fullscreen is
not necessary for video fullscreen. In this scenario, `supportsFullscreen`
incorrectly returns false. To fix, use a setting rather than a compile time
flag.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen const):
* Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultVideoFullscreenRequiresElementFullscreen):
* Source/WebKit/Shared/WebPreferencesDefaultValues.h:
* Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _setupPageConfiguration:]):
Canonical link: https://commits.webkit.org/259225@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
