Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dcad4698521ed9ce12e62d0b91f338d22dd4f8e6
https://github.com/WebKit/WebKit/commit/dcad4698521ed9ce12e62d0b91f338d22dd4f8e6
Author: Žan Doberšek <zdober...@igalia.com>
Date: 2022-11-30 (Wed, 30 Nov 2022)
Changed paths:
M Source/WebKit/CMakeLists.txt
M Source/WebKit/DerivedSources-output.xcfilelist
M Source/WebKit/DerivedSources.make
M Source/WebKit/Platform/IPC/HandleMessage.h
M Source/WebKit/Scripts/generate-message-receiver.py
M Source/WebKit/Scripts/webkit/messages.py
M Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessagesReplies.h
R Source/WebKit/Scripts/webkit/tests/TestWithIfReceiverMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithStreamMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithStreamMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessagesReplies.h
M Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h
R Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessagesReplies.h
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
[WK2] Stop generating message-replies headers
https://bugs.webkit.org/show_bug.cgi?id=248316
Reviewed by Kimmo Kinnunen.
Don't generate the message-replies headers since they are not included
anywhere anymore. The reply-type definitions are also unused, and the
type aliases on each message class are removed. CompletionHandler
validation done for each message that uses such handler is now done
against the ReplyArguments tuple.
A solid amount of code generation in messages.py is removed, and test
cases are updated to reflect that. Build rules and references for the
message-replies headers are also removed.
* Source/WebKit/CMakeLists.txt:
* Source/WebKit/DerivedSources-output.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Platform/IPC/HandleMessage.h:
(IPC::CompletionHandlerValidation<CompletionHandler<void):
(IPC::handleMessageSynchronous):
(IPC::handleMessageSynchronousWantsConnection):
(IPC::handleMessageAsync):
(IPC::handleMessageAsyncWantsConnection):
* Source/WebKit/Scripts/generate-message-receiver.py:
(main):
* Source/WebKit/Scripts/webkit/messages.py:
(reply_arguments_type):
(message_to_struct_declaration):
(forward_declarations_and_headers):
(message_to_reply_forward_declaration): Deleted.
(forward_declarations_and_headers_for_replies): Deleted.
(generate_messages_reply_header): Deleted.
* Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessages.h:
(Messages::TestWithCVPixelBuffer::ReceiveCVPixelBuffer::asyncMessageReplyName):
* Source/WebKit/Scripts/webkit/tests/TestWithCVPixelBufferMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessages.h:
* Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithIfReceiverMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessages.h:
(Messages::TestWithImageData::ReceiveImageData::asyncMessageReplyName):
* Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessages.h:
(Messages::TestWithLegacyReceiver::CreatePlugin::asyncMessageReplyName):
(Messages::TestWithLegacyReceiver::RunJavaScriptAlert::asyncMessageReplyName):
(Messages::TestWithLegacyReceiver::GetPlugins::asyncMessageReplyName):
(Messages::TestWithLegacyReceiver::InterpretKeyEvent::asyncMessageReplyName):
* Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessages.h:
(Messages::TestWithSemaphore::ReceiveSemaphore::asyncMessageReplyName):
* Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessages.h:
* Source/WebKit/Scripts/webkit/tests/TestWithStreamBatchedMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessages.h:
* Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithStreamMessages.h:
(Messages::TestWithStream::SendStringSynchronized::asyncMessageReplyName):
(Messages::TestWithStream::ReceiveMachSendRight::asyncMessageReplyName):
(Messages::TestWithStream::SendAndReceiveMachSendRight::asyncMessageReplyName):
* Source/WebKit/Scripts/webkit/tests/TestWithStreamMessagesReplies.h: Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessages.h:
(Messages::TestWithSuperclass::TestAsyncMessage::asyncMessageReplyName):
(Messages::TestWithSuperclass::TestAsyncMessageWithNoArguments::asyncMessageReplyName):
(Messages::TestWithSuperclass::TestAsyncMessageWithMultipleArguments::asyncMessageReplyName):
(Messages::TestWithSuperclass::TestAsyncMessageWithConnection::asyncMessageReplyName):
* Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessagesReplies.h:
Removed.
* Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessages.h:
(Messages::TestWithoutAttributes::CreatePlugin::asyncMessageReplyName):
(Messages::TestWithoutAttributes::RunJavaScriptAlert::asyncMessageReplyName):
(Messages::TestWithoutAttributes::GetPlugins::asyncMessageReplyName):
(Messages::TestWithoutAttributes::InterpretKeyEvent::asyncMessageReplyName):
* Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessagesReplies.h:
Removed.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/257222@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
