Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 619e29b635b5478321472aa69a23645a8dd018c2
https://github.com/WebKit/WebKit/commit/619e29b635b5478321472aa69a23645a8dd018c2
Author: Hysu Xiong <h...@apple.com>
Date: 2022-11-10 (Thu, 10 Nov 2022)
Changed paths:
M Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py
M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
M Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py
M
Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py
M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
M Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py
M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py
Log Message:
-----------
run-benchmark should allow profiles to be taken during browser benchmark runs
https://bugs.webkit.org/show_bug.cgi?id=247496
rdar://101969614
Reviewed by Dewei Zhu.
We'd like the ability to take profiles in browser benchmarks. To do this, we'll
need to add a context (defined in the driver) to take profiles during test
iterations, and add an argument to the script that toggles this feature on.
In addition:
- Added support for signposts in OSX driver, and refactored
`_launch_url_with_custom_path` to be able to use a previously modified
environment.
- Added an `iteration` argument to `_run_one_test`, as this information may be
useful for labelling profiles later on.
- Clarify and rename references to PGO profiles - previously, we had use the
term "profile generation" across run-benchmark to refer to PGO profile
generation (this has since been replaced with the phrase "PGO profile
generation").
* Tools/Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder.__init__):
(BenchmarkBuilder.__enter__):
* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__):
(BenchmarkRunner._run_benchmark):
(BenchmarkRunner.execute):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver):
(BrowserDriver.profile):
* Tools/Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.prepare_env):
(OSXSafariDriver.launch_url):
(OSXSafariDriver._launch_url_with_custom_path):
(OSXSafariDriver.close_browsers):
* Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(config_argument_parser):
(parse_args):
(run_benchmark_plan):
* Tools/Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
(WebDriverBenchmarkRunner._run_one_test):
* Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner.__init__):
(WebServerBenchmarkRunner._get_result):
(WebServerBenchmarkRunner):
Canonical link: https://commits.webkit.org/256544@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
