Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6a72f93c2426d299da554ee796072305aa3e1de2
      
https://github.com/WebKit/WebKit/commit/6a72f93c2426d299da554ee796072305aa3e1de2
  Author: Tim Nguyen <n...@apple.com>
  Date:   2022-11-04 (Fri, 04 Nov 2022)

  Changed paths:
    A 
LayoutTests/fast/forms/change-input-type-during-setSelectionRange-crash-expected.txt
    A 
LayoutTests/fast/forms/change-input-type-during-setSelectionRange-crash.html
    M Source/WebCore/html/TextFieldInputType.cpp
    M Source/WebCore/html/TextFieldInputType.h

  Log Message:
  -----------
  REGRESSION(255229@main): Do not restore selection when changing input types
https://bugs.webkit.org/show_bug.cgi?id=247472
rdar://101885601

Reviewed by Ryosuke Niwa.

Restoring selection range causes focusin events to fire, and allows the input 
type to be changed when the container is being recreated for a new input type.

* 
LayoutTests/fast/forms/change-input-type-during-setSelectionRange-crash-expected.txt:
 Added.
* LayoutTests/fast/forms/change-input-type-during-setSelectionRange-crash.html: 
Added.
* Source/WebCore/html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createDataListDropdownIndicator):
(WebCore::TextFieldInputType::createContainer):
(WebCore::TextFieldInputType::updateAutoFillButton):
* Source/WebCore/html/TextFieldInputType.h:

Canonical link: https://commits.webkit.org/256323@main


_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to