Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 93d276254db4805331fa1eb9465f70d6d1b43c33
https://github.com/WebKit/WebKit/commit/93d276254db4805331fa1eb9465f70d6d1b43c33
Author: Chris Dumez <cdu...@apple.com>
Date: 2022-10-13 (Thu, 13 Oct 2022)
Changed paths:
M
LayoutTests/editing/execCommand/show-modal-dialog-during-execCommand-expected.txt
M
LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt
M LayoutTests/fast/dom/Window/delete-operations-expected.txt
M LayoutTests/fast/dom/Window/forbid-showModalDialog-expected.txt
M LayoutTests/fast/dom/Window/open-window-min-size-expected.txt
M
LayoutTests/fast/dom/Window/showModalDialog-mandatory-parameter-expected.txt
M
LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt
M
LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt
M LayoutTests/fast/dom/null-page-show-modal-dialog-crash-expected.txt
M LayoutTests/fast/dom/wrapper-identity-expected.txt
M
LayoutTests/http/tests/cookies/document-cookie-after-showModalDialog-expected.txt
M LayoutTests/http/tests/security/cross-frame-access-call-expected.txt
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt
M
LayoutTests/http/tests/security/cross-origin-modal-dialog-base-expected.txt
M
LayoutTests/http/tests/security/navigate-when-restoring-cached-page-expected.txt
M
LayoutTests/http/tests/security/showModalDialog-sync-cross-origin-page-load2-expected.txt
M LayoutTests/js/dom/function-length-expected.txt
M LayoutTests/js/dom/global-function-resolve-expected.txt
M
LayoutTests/platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt
M
LayoutTests/platform/mac-wk1/fast/events/beforeunload-showModalDialog-expected.txt
M
LayoutTests/platform/mac-wk1/fast/events/pagehide-showModalDialog-expected.txt
M
LayoutTests/platform/mac-wk1/fast/events/unload-showModalDialog-expected.txt
M
LayoutTests/platform/mac-wk2/fast/dom/Window/window-lookup-precedence-expected.txt
M Source/WebCore/bindings/js/JSDOMWindowBase.cpp
M Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
M Source/WebCore/page/Quirks.cpp
M Source/WebCore/page/Quirks.h
Log Message:
-----------
Regression(252759@main) Unable to log into pandora.com
https://bugs.webkit.org/show_bug.cgi?id=246430
rdar://100243111
Reviewed by Geoffrey Garen and Ryosuke Niwa.
We're unable to log into pandora.com since un-exposing window.showModalDialog()
in 252759@main. Pandora does not actually seem to call showModalDialog() but
they are calling its getter on the Window object. It is unclear why this is
causing log in to fail since there is no JS error (and other browsers don't
expose showModalDialog either).
To resolve the issue for now, I am adding a quirk to re-expose showModalDialog
on pandora.com. However, since they're not calling it, I am merely using
`undefined` as value for the property.
* Source/WebCore/bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::finishCreation):
* Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSC_DEFINE_CUSTOM_GETTER):
* Source/WebCore/page/Quirks.cpp:
(WebCore::Quirks::shouldExposeShowModalDialog const):
* Source/WebCore/page/Quirks.h:
Canonical link: https://commits.webkit.org/255521@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
