Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3a3a97e3b21468b4283bdbf56d66da3299715dbc
https://github.com/WebKit/WebKit/commit/3a3a97e3b21468b4283bdbf56d66da3299715dbc
Author: Antoine Quint <grao...@webkit.org>
Date: 2022-10-06 (Thu, 06 Oct 2022)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-2d-getComputedStyle-001.html
M Source/WebCore/animation/KeyframeEffect.cpp
M Source/WebCore/animation/WebAnimation.cpp
M Source/WebCore/css/ComputedStyleExtractor.cpp
M Source/WebCore/css/ComputedStyleExtractor.h
Log Message:
-----------
REGRESSION(254760@main): mobile version of apple.com/iphone-14 doesn't display
https://bugs.webkit.org/show_bug.cgi?id=246122
rdar://100814764
Reviewed by Antti Koivisto.
We used to identify a null renderer in computedTransform() as a signal that the
"computed" value
for "transform" was requested rather than the "resolved" value. The difference
is significant
because a the "resolved" value for "transform" for an element that has
"display: none", and thus
no renderer is "none". However, we failed to identify this case and would
return the <transform-list>
type.
The same way that ComputedStyleExtractor::propertyValue() takes in an argument
to specify the value
type requested, we add a new argument to
ComputedStyleExtractor::valueForPropertyInStyle() which we
pass to computedTransform() to distinguish between the "display: none" case and
the "computed" value
case.
We also ask for the "computed" value from WebAnimation::commitStyles() and when
parsing keyframe styles
in the Web Animations API. We were already requesting such style through
ComputedStyleExtractor::propertyValue()
in the CSS Typed OM computedStyleMap() function.
Since this case was not tested before, we add some new assertions in an
existing WPT test to check that
setting "display: none" on an element with a "transform" set does indeed return
"none".
Incidentally, this brought a couple of new WPT PASS results for ::first-letter
and ::first-line.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-letter-allowed-properties-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/first-line-allowed-properties-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/transform-2d-getComputedStyle-001.html:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::getKeyframes):
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::commitStyles):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::computedTransform):
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
* Source/WebCore/css/ComputedStyleExtractor.h:
Canonical link: https://commits.webkit.org/255216@main
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
