Title: [295739] trunk/Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp
- Revision
- 295739
- Author
- [email protected]
- Date
- 2022-06-22 11:12:01 -0700 (Wed, 22 Jun 2022)
Log Message
[GLIB] Fix invalid D-Bus name for MPRIS
https://bugs.webkit.org/show_bug.cgi?id=241807
Reviewed by Philippe Normand.
A mistake introduced in #1651 used a bus name where a segment started with
a number which is not allowed. Change this to `.instance-$INSTANCE_ID` to fix that.
* Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp:
(WebCore::MediaSessionGLib::MediaSessionGLib):
Canonical link: https://commits.webkit.org/251744@main
Modified Paths
Diff
Modified: trunk/Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp (295738 => 295739)
--- trunk/Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp 2022-06-22 18:02:36 UTC (rev 295738)
+++ trunk/Source/WebCore/platform/audio/glib/MediaSessionGLib.cpp 2022-06-22 18:12:01 UTC (rev 295739)
@@ -222,7 +222,7 @@
}
const auto& applicationID = getApplicationID();
- m_instanceId = applicationID.isEmpty() ? makeString("org.mpris.MediaPlayer2.webkit.instance", getpid(), "-", identifier.toUInt64()) : makeString("org.mpris.MediaPlayer2.", applicationID.ascii().data(), ".", identifier.toUInt64());
+ m_instanceId = applicationID.isEmpty() ? makeString("org.mpris.MediaPlayer2.webkit.instance", getpid(), "-", identifier.toUInt64()) : makeString("org.mpris.MediaPlayer2.", applicationID.ascii().data(), ".instance-", identifier.toUInt64());
m_ownerId = g_bus_own_name_on_connection(m_connection.get(), m_instanceId.ascii().data(), G_BUS_NAME_OWNER_FLAGS_NONE, nullptr, nullptr, this, nullptr);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
