Title: [292354] trunk/Source
Revision
292354
Author
timothy_hor...@apple.com
Date
2022-04-04 15:28:03 -0700 (Mon, 04 Apr 2022)

Log Message

Remove the 'sw_vp9_decoder_on_battery' system feature flag
https://bugs.webkit.org/show_bug.cgi?id=238761

Reviewed by Eric Carlson.

Source/WebKit:

* FeatureFlags/WebKit-appletvos.plist:
* FeatureFlags/WebKit-ios.plist:
* FeatureFlags/WebKit-macos.plist:
* FeatureFlags/WebKit-watchos.plist:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultVP9SWDecoderEnabledOnBattery): Deleted.

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:
Switch this to a standard experimental feature.
Also, remove the WebKitLegacy case, as it is not used there.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (292353 => 292354)


--- trunk/Source/WTF/ChangeLog	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WTF/ChangeLog	2022-04-04 22:28:03 UTC (rev 292354)
@@ -1,5 +1,16 @@
 2022-04-04  Tim Horton  <timothy_hor...@apple.com>
 
+        Remove the 'sw_vp9_decoder_on_battery' system feature flag
+        https://bugs.webkit.org/show_bug.cgi?id=238761
+
+        Reviewed by Eric Carlson.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+        Switch this to a standard experimental feature.
+        Also, remove the WebKitLegacy case, as it is not used there.
+
+2022-04-04  Tim Horton  <timothy_hor...@apple.com>
+
         Remove the 'async frame and overflow scrolling' system feature flag
         https://bugs.webkit.org/show_bug.cgi?id=238758
 

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (292353 => 292354)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2022-04-04 22:28:03 UTC (rev 292354)
@@ -1515,7 +1515,6 @@
     WebKit:
       default: WebKit::defaultVP9DecoderEnabled()
 
-# FIXME: Is this implemented for WebKitLegacy? If not, this should be excluded from WebKitLegacy entirely.
 VP9SWDecoderEnabledOnBattery:
   type: bool
   humanReadableName: "VP9 SW decoder on battery"
@@ -1523,10 +1522,8 @@
   webcoreBinding: none
   condition: ENABLE(VP9)
   defaultValue:
-    WebKitLegacy:
+    WebKit:
       default: false
-    WebKit:
-      default: WebKit::defaultVP9SWDecoderEnabledOnBattery()
 
 VisualViewportAPIEnabled:
   type: bool

Modified: trunk/Source/WebKit/ChangeLog (292353 => 292354)


--- trunk/Source/WebKit/ChangeLog	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WebKit/ChangeLog	2022-04-04 22:28:03 UTC (rev 292354)
@@ -1,5 +1,19 @@
 2022-04-04  Tim Horton  <timothy_hor...@apple.com>
 
+        Remove the 'sw_vp9_decoder_on_battery' system feature flag
+        https://bugs.webkit.org/show_bug.cgi?id=238761
+
+        Reviewed by Eric Carlson.
+
+        * FeatureFlags/WebKit-appletvos.plist:
+        * FeatureFlags/WebKit-ios.plist:
+        * FeatureFlags/WebKit-macos.plist:
+        * FeatureFlags/WebKit-watchos.plist:
+        * Shared/WebPreferencesDefaultValues.cpp:
+        (WebKit::defaultVP9SWDecoderEnabledOnBattery): Deleted.
+
+2022-04-04  Tim Horton  <timothy_hor...@apple.com>
+
         Remove the 'async frame and overflow scrolling' system feature flag
         https://bugs.webkit.org/show_bug.cgi?id=238758
 

Modified: trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist (292353 => 292354)


--- trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist	2022-04-04 22:28:03 UTC (rev 292354)
@@ -42,11 +42,6 @@
 			<true/>
 		</dict>
 	</dict>
-	<key>sw_vp9_decoder_on_battery</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
 	<key>vp9_decoder</key>
 	<dict>
 		<key>Enabled</key>

Modified: trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist (292353 => 292354)


--- trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist	2022-04-04 22:28:03 UTC (rev 292354)
@@ -42,11 +42,6 @@
 			<true/>
 		</dict>
 	</dict>
-	<key>sw_vp9_decoder_on_battery</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
 	<key>vp9_decoder</key>
 	<dict>
 		<key>Enabled</key>

Modified: trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist (292353 => 292354)


--- trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist	2022-04-04 22:28:03 UTC (rev 292354)
@@ -42,11 +42,6 @@
 			<true/>
 		</dict>
 	</dict>
-	<key>sw_vp9_decoder_on_battery</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
 	<key>vp9_decoder</key>
 	<dict>
 		<key>Enabled</key>

Modified: trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist (292353 => 292354)


--- trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist	2022-04-04 22:28:03 UTC (rev 292354)
@@ -42,11 +42,6 @@
 			<true/>
 		</dict>
 	</dict>
-	<key>sw_vp9_decoder_on_battery</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
 	<key>vp9_decoder</key>
 	<dict>
 		<key>Enabled</key>

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (292353 => 292354)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2022-04-04 22:28:03 UTC (rev 292354)
@@ -272,10 +272,6 @@
     return isFeatureFlagEnabled("vp9_decoder", true);
 }
 
-bool defaultVP9SWDecoderEnabledOnBattery()
-{
-    return isFeatureFlagEnabled("sw_vp9_decoder_on_battery", false);
-}
 #endif // ENABLE(VP9)
 
 #if ENABLE(MEDIA_SOURCE)

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (292353 => 292354)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2022-04-04 22:24:52 UTC (rev 292353)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2022-04-04 22:28:03 UTC (rev 292354)
@@ -90,7 +90,6 @@
 #if ENABLE(VP9)
 bool defaultVP8DecoderEnabled();
 bool defaultVP9DecoderEnabled();
-bool defaultVP9SWDecoderEnabledOnBattery();
 #endif
 
 #if ENABLE(MEDIA_SOURCE)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to