Title: [107382] trunk/Source/WebCore
- Revision
- 107382
- Author
- hara...@chromium.org
- Date
- 2012-02-10 01:28:05 -0800 (Fri, 10 Feb 2012)
Log Message
Remove [ConvertingNullStringTo] from CloseEvent.idl
https://bugs.webkit.org/show_bug.cgi?id=78328
Reviewed by Adam Barth.
In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
(although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).
Anyway, the spec says that "The reason attribute must return the value it was
initialized to. When the object is created, this attribute must be initialized to empty string."
http://dev.w3.org/html5/websockets/#event-definitions
Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.
Test: fast/events/constructors/close-event-constructor.html
* websockets/CloseEvent.idl:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (107381 => 107382)
--- trunk/Source/WebCore/ChangeLog 2012-02-10 09:13:36 UTC (rev 107381)
+++ trunk/Source/WebCore/ChangeLog 2012-02-10 09:28:05 UTC (rev 107382)
@@ -1,3 +1,22 @@
+2012-02-10 Kentaro Hara <hara...@chromium.org>
+
+ Remove [ConvertingNullStringTo] from CloseEvent.idl
+ https://bugs.webkit.org/show_bug.cgi?id=78328
+
+ Reviewed by Adam Barth.
+
+ In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
+ (although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).
+
+ Anyway, the spec says that "The reason attribute must return the value it was
+ initialized to. When the object is created, this attribute must be initialized to empty string."
+ http://dev.w3.org/html5/websockets/#event-definitions
+ Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.
+
+ Test: fast/events/constructors/close-event-constructor.html
+
+ * websockets/CloseEvent.idl:
+
2012-02-10 Pavel Feldman <pfeld...@google.com>
[Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
Modified: trunk/Source/WebCore/websockets/CloseEvent.idl (107381 => 107382)
--- trunk/Source/WebCore/websockets/CloseEvent.idl 2012-02-10 09:13:36 UTC (rev 107381)
+++ trunk/Source/WebCore/websockets/CloseEvent.idl 2012-02-10 09:28:05 UTC (rev 107382)
@@ -36,7 +36,7 @@
] CloseEvent : Event {
readonly attribute [InitializedByEventConstructor] boolean wasClean;
readonly attribute [InitializedByEventConstructor] unsigned short code;
- readonly attribute [InitializedByEventConstructor, ConvertingNullStringTo=Undefined] DOMString reason;
+ readonly attribute [InitializedByEventConstructor] DOMString reason;
};
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
