Title: [287681] trunk/Source/WebCore
- Revision
- 287681
- Author
- j...@apple.com
- Date
- 2022-01-06 05:03:26 -0800 (Thu, 06 Jan 2022)
Log Message
length argument passed to didReceiveData can never be negative.
https://bugs.webkit.org/show_bug.cgi?id=234916
rdar://problem/87190340
Reviewed by Youenn Fablet.
Signed int argument will be removed in bug 232424.
No change in observable behaviour. Covered by existing tests.
* inspector/agents/InspectorNetworkAgent.cpp:
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didReceiveData):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::didReceiveData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (287680 => 287681)
--- trunk/Source/WebCore/ChangeLog 2022-01-06 11:41:53 UTC (rev 287680)
+++ trunk/Source/WebCore/ChangeLog 2022-01-06 13:03:26 UTC (rev 287681)
@@ -1,3 +1,21 @@
+2022-01-06 Jean-Yves Avenard <j...@apple.com>
+
+ length argument passed to didReceiveData can never be negative.
+ https://bugs.webkit.org/show_bug.cgi?id=234916
+ rdar://problem/87190340
+
+ Reviewed by Youenn Fablet.
+
+ Signed int argument will be removed in bug 232424.
+
+ No change in observable behaviour. Covered by existing tests.
+
+ * inspector/agents/InspectorNetworkAgent.cpp:
+ * workers/WorkerScriptLoader.cpp:
+ (WebCore::WorkerScriptLoader::didReceiveData):
+ * xml/XMLHttpRequest.cpp:
+ (WebCore::XMLHttpRequest::didReceiveData):
+
2022-01-06 Youenn Fablet <you...@apple.com>
WorkerMessagePortChannelProvider::takeAllMessagesForPort should guarantee execution of the takeMessagePort callback
Modified: trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp (287680 => 287681)
--- trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp 2022-01-06 11:41:53 UTC (rev 287680)
+++ trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp 2022-01-06 13:03:26 UTC (rev 287681)
@@ -129,9 +129,6 @@
if (!dataLength)
return;
- if (dataLength == -1)
- dataLength = strlen(reinterpret_cast<const char*>(data));
-
m_responseText.append(m_decoder->decode(data, dataLength));
}
Modified: trunk/Source/WebCore/workers/WorkerScriptLoader.cpp (287680 => 287681)
--- trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2022-01-06 11:41:53 UTC (rev 287680)
+++ trunk/Source/WebCore/workers/WorkerScriptLoader.cpp 2022-01-06 13:03:26 UTC (rev 287681)
@@ -215,9 +215,6 @@
if (!len)
return;
- if (len == -1)
- len = strlen(reinterpret_cast<const char*>(data));
-
m_script.append(m_decoder->decode(data, len));
}
Modified: trunk/Source/WebCore/xml/XMLHttpRequest.cpp (287680 => 287681)
--- trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2022-01-06 11:41:53 UTC (rev 287680)
+++ trunk/Source/WebCore/xml/XMLHttpRequest.cpp 2022-01-06 13:03:26 UTC (rev 287681)
@@ -1055,9 +1055,6 @@
if (!len)
return;
- if (len == -1)
- len = strlen(reinterpret_cast<const char*>(data));
-
if (useDecoder)
m_responseBuilder.append(m_decoder->decode(data, len));
else {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
