Title: [283735] trunk
- Revision
- 283735
- Author
- commit-qu...@webkit.org
- Date
- 2021-10-07 12:48:16 -0700 (Thu, 07 Oct 2021)
Log Message
[GTK][WPE] Disable privateClickMeasurement when creating the network process
https://bugs.webkit.org/show_bug.cgi?id=231175
Patch by Arcady Goldmints-Orlov <agoldmi...@igalia.com> on 2021-10-07
Reviewed by Adrian Perez de Castro.
Source/WebKit:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
LayoutTests:
Skip privateClickMeasurement tests on GTK and WPE.
* platform/glib/TestExpectations:
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-null-content-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-wrong-content-type-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt: Removed.
* platform/glib/http/tests/privateClickMeasurement/store-private-click-measurement-expected.txt: Removed.
* platform/wpe/TestExpectations:
Modified Paths
Removed Paths
- trunk/LayoutTests/platform/glib/http/tests/privateClickMeasurement/
Diff
Modified: trunk/LayoutTests/ChangeLog (283734 => 283735)
--- trunk/LayoutTests/ChangeLog 2021-10-07 19:31:35 UTC (rev 283734)
+++ trunk/LayoutTests/ChangeLog 2021-10-07 19:48:16 UTC (rev 283735)
@@ -1,3 +1,29 @@
+2021-10-07 Arcady Goldmints-Orlov <agoldmi...@igalia.com>
+
+ [GTK][WPE] Disable privateClickMeasurement when creating the network process
+ https://bugs.webkit.org/show_bug.cgi?id=231175
+
+ Reviewed by Adrian Perez de Castro.
+
+ Skip privateClickMeasurement tests on GTK and WPE.
+
+ * platform/glib/TestExpectations:
+ * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-cross-site-image-redirect-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-fetch-keepalive-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-ephemeral-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-with-priority-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-without-priority-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/conversion-disabled-in-ephemeral-session-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-null-content-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/private-click-measurement-with-source-nonce-wrong-content-type-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-higher-priority-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/second-attribution-converted-with-lower-priority-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/second-conversion-with-higher-priority-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/second-conversion-with-lower-priority-expected.txt: Removed.
+ * platform/glib/http/tests/privateClickMeasurement/store-private-click-measurement-expected.txt: Removed.
+ * platform/wpe/TestExpectations:
+
2021-10-07 Ayumi Kojima <ayumi_koj...@apple.com>
security/contentSecurityPolicy/video-with-blob-url-allowed-by-media-src-star.html and security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html are flaky.
Modified: trunk/LayoutTests/platform/glib/TestExpectations (283734 => 283735)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-10-07 19:31:35 UTC (rev 283734)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-10-07 19:48:16 UTC (rev 283735)
@@ -772,8 +772,6 @@
webkit.org/b/217961 http/tests/images/mp4-partial-load.html [ Timeout Pass ]
-webkit.org/b/224109 http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html [ Failure Pass ]
-
#////////////////////////////////////////////////////////////////////////////////////////
# End of HTTP-related bugs
#////////////////////////////////////////////////////////////////////////////////////////
@@ -1864,6 +1862,9 @@
http/tests/webshare [ Skip ]
+# privateClickMeasurement is disabled on glib
+http/tests/privateClickMeasurement [ Skip ]
+
#////////////////////////////////////////////////////////////////////////////////////////
# End of UNSUPPORTED tests.
#////////////////////////////////////////////////////////////////////////////////////////
@@ -2491,9 +2492,6 @@
webkit.org/b/230315 imported/w3c/web-platform-tests/mathml/presentation-markup/direction/direction-006.html [ ImageOnlyFailure ]
-webkit.org/b/230317 http/tests/privateClickMeasurement/expired-attribution-report-gets-sent-on-session-start.html [ Failure ]
-webkit.org/b/230317 http/tests/privateClickMeasurement/send-attribution-conversion-request.html [ Failure ]
-
# End: Common failures between GTK and WPE.
#////////////////////////////////////////////////////////////////////////////////////////
Modified: trunk/LayoutTests/platform/wpe/TestExpectations (283734 => 283735)
--- trunk/LayoutTests/platform/wpe/TestExpectations 2021-10-07 19:31:35 UTC (rev 283734)
+++ trunk/LayoutTests/platform/wpe/TestExpectations 2021-10-07 19:48:16 UTC (rev 283735)
@@ -220,7 +220,6 @@
webkit.org/b/221377 [ Debug ] fast/text/hyphenation-unknown-locale.html [ Skip ]
# Link target
-webkit.org/b/218553 http/tests/privateClickMeasurement/attribution-conversion-through-image-redirect-in-new-window.html [ Timeout ]
webkit.org/b/212083 loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag-from-subframe.html
webkit.org/b/212083 loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-with-flag.html
webkit.org/b/212083 loader/navigation-policy/should-open-external-urls/user-gesture-target-blank-without-flag-from-subframe.html
Modified: trunk/Source/WebKit/ChangeLog (283734 => 283735)
--- trunk/Source/WebKit/ChangeLog 2021-10-07 19:31:35 UTC (rev 283734)
+++ trunk/Source/WebKit/ChangeLog 2021-10-07 19:48:16 UTC (rev 283735)
@@ -1,3 +1,13 @@
+2021-10-07 Arcady Goldmints-Orlov <agoldmi...@igalia.com>
+
+ [GTK][WPE] Disable privateClickMeasurement when creating the network process
+ https://bugs.webkit.org/show_bug.cgi?id=231175
+
+ Reviewed by Adrian Perez de Castro.
+
+ * UIProcess/Network/NetworkProcessProxy.cpp:
+ (WebKit::NetworkProcessProxy::sendCreationParametersToNewProcess):
+
2021-10-07 Aditya Keerthi <akeer...@apple.com>
Fix the macCatalyst build
Modified: trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp (283734 => 283735)
--- trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-10-07 19:31:35 UTC (rev 283734)
+++ trunk/Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp 2021-10-07 19:48:16 UTC (rev 283735)
@@ -174,6 +174,10 @@
});
#endif
+#if PLATFORM(GTK) || PLATFORM(WPE)
+ parameters.enablePrivateClickMeasurement = false;
+#endif
+
WebProcessPool::platformInitializeNetworkProcess(parameters);
send(Messages::NetworkProcess::InitializeNetworkProcess(parameters), 0);
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
